From a70553f7d8a7006cea6484ab1104a5120305762f Mon Sep 17 00:00:00 2001 From: Yasser Date: Fri, 8 Jan 2021 00:31:30 +0100 Subject: [PATCH] Do not create HPA if default backend not enabled Update annotations Do not create HPA if default backend not enabled --- charts/ingress-nginx/CHANGELOG.md | 4 ++++ charts/ingress-nginx/Chart.yaml | 4 ++-- charts/ingress-nginx/templates/default-backend-hpa.yaml | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/charts/ingress-nginx/CHANGELOG.md b/charts/ingress-nginx/CHANGELOG.md index e1a20689d..c777524e5 100644 --- a/charts/ingress-nginx/CHANGELOG.md +++ b/charts/ingress-nginx/CHANGELOG.md @@ -4,6 +4,10 @@ This file documents all notable changes to [ingress-nginx](https://github.com/ku ### Unreleased +### 3.20.0 + +- [] [#6730](https://github.com/kubernetes/ingress-nginx/pull/6730) Do not create HPA for defaultBackend if not enabled. + ### 3.19.0 - Update ingress-nginx v0.43.0 diff --git a/charts/ingress-nginx/Chart.yaml b/charts/ingress-nginx/Chart.yaml index 886a12b54..a78c416ad 100644 --- a/charts/ingress-nginx/Chart.yaml +++ b/charts/ingress-nginx/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: ingress-nginx # When the version is modified, make sure the artifacthub.io/changes list is updated # Also update CHANGELOG.md -version: 3.19.0 +version: 3.20.0 appVersion: 0.43.0 home: https://github.com/kubernetes/ingress-nginx description: Ingress controller for Kubernetes using NGINX as a reverse proxy and load balancer @@ -21,4 +21,4 @@ annotations: # List of changes for the release in artifacthub.io # https://artifacthub.io/packages/helm/ingress-nginx/ingress-nginx?modal=changelog artifacthub.io/changes: | - - Update ingress-nginx v0.43.0 + - Do not create HPA for defaultbackend if not enabled. diff --git a/charts/ingress-nginx/templates/default-backend-hpa.yaml b/charts/ingress-nginx/templates/default-backend-hpa.yaml index 36b8bf221..a007d0315 100644 --- a/charts/ingress-nginx/templates/default-backend-hpa.yaml +++ b/charts/ingress-nginx/templates/default-backend-hpa.yaml @@ -1,4 +1,4 @@ -{{- if .Values.defaultBackend.autoscaling.enabled }} +{{- if and .Values.defaultBackend.enabled .Values.defaultBackend.autoscaling.enabled }} apiVersion: autoscaling/v2beta1 kind: HorizontalPodAutoscaler metadata: