Cloud Build: Some chores. (#11757)

* Cloud Build: Remove comment.

* Cloud Build: Add newlines at EOF.

* Cloud Build: Align comment.

* Cloud Build: Remove trailing slash.

* Cloud Build: Remove quotes.

* Cloud Build: Align indentation.

* Cloud Build: Improve quotes.

* Cloud Build: Put arguments in one line.

* Cloud Build: Bump image.

* Cloud Build: Reorder entrypoint.

* Cloud Build: Adjust timeouts.

* Cloud Build: Remove useless files.

* Cloud Build: Remove `substitution_option`.

---------

Co-authored-by: Marco Ebert <marco_ebert@icloud.com>

cloudbuild.yaml

@@ -1,25 +1,14 @@
-# See https://cloud.google.com/cloud-build/docs/build-config
+substitutions:
-
+  _PULL_BASE_SHA: "12345"
-timeout: 18000s
-options:
-  substitution_option: ALLOW_LOOSE
 steps:
-  - name: 'gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90'
+  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240523-a15ad90fc9
-    entrypoint: bash
     env:
-      - DOCKER_CLI_EXPERIMENTAL=enabled
       - REGISTRY=gcr.io/k8s-staging-ingress-nginx
       - REPO_INFO=https://github.com/kubernetes/ingress-nginx
-      - COMMIT_SHA=$_PULL_BASE_SHA
+      - COMMIT_SHA=${_PULL_BASE_SHA}
-      - BUILD_ID=$BUILD_ID
+      - BUILD_ID=${BUILD_ID}
-      - HOME=/root
+    entrypoint: bash
-      - USER=root
     args:
-    - -c
+      - -c
-    - |
+      - gcloud auth configure-docker && make release
-      gcloud auth configure-docker \
+timeout: 1800s
-      && make release
-substitutions:
-  _GIT_TAG: "12345"
-  _PULL_BASE_REF: "main"
-  _PULL_BASE_SHA: '12345'

images/cfssl/cloudbuild.yaml

@@ -1,17 +1,8 @@
-timeout: 600s
-options:
-  substitution_option: ALLOW_LOOSE
 steps:
-  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90
+  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240523-a15ad90fc9
-    entrypoint: bash
     env:
-      - DOCKER_CLI_EXPERIMENTAL=enabled
       - REGISTRY=gcr.io/k8s-staging-ingress-nginx
-      # default cloudbuild has HOME=/builder/home and docker buildx is in /root/.docker/cli-plugins/docker-buildx
+    entrypoint: bash
-      # set the home to /root explicitly to if using docker buildx
-      - HOME=/root
     args:
-    - -c
+      - -c
-    - |
+      - gcloud auth configure-docker && cd images && make NAME=cfssl push
-      gcloud auth configure-docker \
-      && cd images && make NAME=cfssl push

images/custom-error-pages/README.md

@@ -1,3 +0,0 @@
-# custom-error-pages
-
-Example of Custom error pages for the Ingress-Nginx Controller

images/custom-error-pages/cloudbuild.yaml

@@ -1,17 +1,9 @@
-timeout: 1800s
-options:
-  substitution_option: ALLOW_LOOSE
 steps:
-  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90
+  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240523-a15ad90fc9
-    entrypoint: bash
     env:
-      - DOCKER_CLI_EXPERIMENTAL=enabled
       - REGISTRY=gcr.io/k8s-staging-ingress-nginx
-      # default cloudbuild has HOME=/builder/home and docker buildx is in /root/.docker/cli-plugins/docker-buildx
+    entrypoint: bash
-      # set the home to /root explicitly to if using docker buildx
-      - HOME=/root
     args:
-    - -c
+      - -c
-    - |
+      - gcloud auth configure-docker && cd images && make NAME=custom-error-pages push
-      gcloud auth configure-docker \
+timeout: 3600s
-      && cd images/ && make NAME=custom-error-pages push

images/ext-auth-example-authsvc/cloudbuild.yaml

@@ -1,19 +1,8 @@
-timeout: 1200s
-options:
-  substitution_option: ALLOW_LOOSE
-  # job builds a multi-arch docker image for amd64,arm,arm64 and s390x.
-  machineType: E2_HIGHCPU_8
 steps:
-  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90
+  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240523-a15ad90fc9
-    entrypoint: bash
     env:
-      - DOCKER_CLI_EXPERIMENTAL=enabled
       - REGISTRY=gcr.io/k8s-staging-ingress-nginx
-      # default cloudbuild has HOME=/builder/home and docker buildx is in /root/.docker/cli-plugins/docker-buildx
+    entrypoint: bash
-      # set the home to /root explicitly to if using docker buildx
-      - HOME=/root
     args:
-    - -c
+      - -c
-    - |
+      - gcloud auth configure-docker && cd images && make NAME=ext-auth-example-authsvc push
-      gcloud auth configure-docker \
-      && cd images/ && make NAME=ext-auth-example-authsvc push

images/fastcgi-helloserver/cloudbuild.yaml

@@ -1,17 +1,9 @@
-timeout: 1800s
-options:
-  substitution_option: ALLOW_LOOSE
 steps:
-  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90
+  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240523-a15ad90fc9
-    entrypoint: bash
     env:
-      - DOCKER_CLI_EXPERIMENTAL=enabled
       - REGISTRY=gcr.io/k8s-staging-ingress-nginx
-      # default cloudbuild has HOME=/builder/home and docker buildx is in /root/.docker/cli-plugins/docker-buildx
+    entrypoint: bash
-      # set the home to /root explicitly to if using docker buildx
-      - HOME=/root
     args:
-    - -c
+      - -c
-    - |
+      - gcloud auth configure-docker && cd images && make NAME=fastcgi-helloserver push
-      gcloud auth configure-docker \
+timeout: 3600s
-      && cd images/ && make NAME=fastcgi-helloserver push

images/go-grpc-greeter-server/cloudbuild.yaml

@@ -1,19 +1,8 @@
-timeout: 1200s
-options:
-  substitution_option: ALLOW_LOOSE
-  # job builds a multi-arch docker image for amd64,arm,arm64 and s390x.
-  machineType: E2_HIGHCPU_8
 steps:
-  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90
+  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240523-a15ad90fc9
-    entrypoint: bash
     env:
-      - DOCKER_CLI_EXPERIMENTAL=enabled
       - REGISTRY=gcr.io/k8s-staging-ingress-nginx
-      # default cloudbuild has HOME=/builder/home and docker buildx is in /root/.docker/cli-plugins/docker-buildx
+    entrypoint: bash
-      # set the home to /root explicitly to if using docker buildx
-      - HOME=/root
     args:
-    - -c
+      - -c
-    - |
+      - gcloud auth configure-docker && cd images && make NAME=go-grpc-greeter-server push
-      gcloud auth configure-docker \
-      && cd images/ && make NAME=go-grpc-greeter-server push

images/httpbun/cloudbuild.yaml

@@ -1,19 +1,9 @@
-timeout: 1200s
-options:
-  substitution_option: ALLOW_LOOSE
-  # job builds a multi-arch docker image for amd64,arm,arm64 and s390x.
-  machineType: E2_HIGHCPU_8
 steps:
-  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90
+  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240523-a15ad90fc9
-    entrypoint: bash
     env:
-      - DOCKER_CLI_EXPERIMENTAL=enabled
       - REGISTRY=gcr.io/k8s-staging-ingress-nginx
-      # default cloudbuild has HOME=/builder/home and docker buildx is in /root/.docker/cli-plugins/docker-buildx
+    entrypoint: bash
-      # set the home to /root explicitly to if using docker buildx
-      - HOME=/root
     args:
-    - -c
+      - -c
-    - |
+      - gcloud auth configure-docker && cd images && make NAME=httpbun push
-      gcloud auth configure-docker \
+timeout: 3600s
-      && cd images/ && make NAME=httpbun push

images/kube-webhook-certgen/cloudbuild.yaml

@@ -1,32 +1,9 @@
-
-# Copyright 2021 The Kubernetes Authors. All rights reserved.
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-timeout: 10800s
-options:
-  substitution_option: ALLOW_LOOSE
 steps:
-  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90
+  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240523-a15ad90fc9
-    entrypoint: bash
     env:
-      - DOCKER_CLI_EXPERIMENTAL=enabled
       - REGISTRY=gcr.io/k8s-staging-ingress-nginx
-      # default cloudbuild has HOME=/builder/home and docker buildx is in /root/.docker/cli-plugins/docker-buildx
+    entrypoint: bash
-      # set the home to /root explicitly to if using docker buildx
-      - HOME=/root
     args:
-    - -c
+      - -c
-    - |
+      - gcloud auth configure-docker && cd images && make NAME=kube-webhook-certgen push
-      gcloud auth configure-docker \
+timeout: 1800s
-      && cd images/ && make NAME=kube-webhook-certgen push

images/nginx-1.25/cloudbuild.yaml

@@ -1,17 +1,12 @@
-timeout: 10800s
 options:
-  substitution_option: ALLOW_LOOSE
+  # Increase machine type for multi-arch builds.
-  # job builds a multi-arch docker image for amd64,arm,arm64
   machineType: E2_HIGHCPU_32
 steps:
-  - name: 'gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90'
+  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240523-a15ad90fc9
-    entrypoint: bash
     env:
-      - DOCKER_CLI_EXPERIMENTAL=enabled
       - REGISTRY=gcr.io/k8s-staging-ingress-nginx
-      - HOME=/root
+    entrypoint: bash
     args:
-    - -c
+      - -c
-    - |
+      - gcloud auth configure-docker && cd images/nginx-1.25 && make push
-      gcloud auth configure-docker \
+timeout: 7200s
-      && cd images/nginx-1.25 && make push

images/nginx/cloudbuild.yaml

@@ -1,17 +1,12 @@
-timeout: 10800s
 options:
-  substitution_option: ALLOW_LOOSE
+  # Increase machine type for multi-arch builds.
-  # job builds a multi-arch docker image for amd64,arm,arm64 and s390x.
   machineType: E2_HIGHCPU_32
 steps:
-  - name: 'gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90'
+  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240523-a15ad90fc9
-    entrypoint: bash
     env:
-      - DOCKER_CLI_EXPERIMENTAL=enabled
       - REGISTRY=gcr.io/k8s-staging-ingress-nginx
-      - HOME=/root
+    entrypoint: bash
     args:
-    - -c
+      - -c
-    - |
+      - gcloud auth configure-docker && cd images/nginx && make push
-      gcloud auth configure-docker \
+timeout: 7200s
-      && cd images/nginx && make push

images/nginx/rc.yaml

@@ -1,44 +0,0 @@
-apiVersion: v1
-kind: Service
-metadata:
-  name: nginx
-  labels:
-    app.kubernetes.io/name: ingress-nginx
-    app.kubernetes.io/part-of: ingress-nginx
-spec:
-  type: NodePort
-  ports:
-    - port: 80
-      protocol: TCP
-      name: http
-    - port: 443
-      protocol: TCP
-      name: https
-  selector:
-    app.kubernetes.io/name: ingress-nginx
-    app.kubernetes.io/part-of: ingress-nginx
----
-apiVersion: v1
-kind: ReplicationController
-metadata:
-  name: nginx
-  labels:
-    app.kubernetes.io/name: ingress-nginx
-    app.kubernetes.io/part-of: ingress-nginx
-spec:
-  replicas: 1
-  selector:
-    app.kubernetes.io/name: ingress-nginx
-    app.kubernetes.io/part-of: ingress-nginx
-  template:
-    metadata:
-      labels:
-        app.kubernetes.io/name: ingress-nginx
-        app.kubernetes.io/part-of: ingress-nginx
-    spec:
-      containers:
-        - name: nginx
-          image: registry.k8s.io/ingress-nginx/nginx:c5766dc011965f22fac2f4437e86d0fd9960a50c@sha256:94ff9b435a5f3f4570bbdaed4a3a523f63a54ce2ad6b132b5640bae2af5d9d90
-          ports:
-            - containerPort: 80
-            - containerPort: 443

images/opentelemetry/README.md

@@ -1,5 +0,0 @@
-# OpenTelemetry library builder
-
-**How to use this image:**
-This image only contains the necessary files in /usr/local and /etc/nginx/opentelemetry to 
-be copied to Ingress Controller deployment when OpenTelemetry is enabled

images/opentelemetry/cloudbuild.yaml

@@ -1,20 +1,12 @@
-timeout: 10800s
 options:
-  substitution_option: ALLOW_LOOSE
+  # Increase machine type for multi-arch builds.
-  # job builds a multi-arch docker image for amd64,arm,arm64 and s390x.
+  machineType: E2_HIGHCPU_8
-  machineType: E2_HIGHCPU_32
 steps:
-  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90
+  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240523-a15ad90fc9
-    entrypoint: bash
     env:
-      - DOCKER_CLI_EXPERIMENTAL=enabled
       - REGISTRY=gcr.io/k8s-staging-ingress-nginx
-      # default cloudbuild has HOME=/builder/home and docker buildx is in /root/.docker/cli-plugins/docker-buildx
+    entrypoint: bash
-      # set the home to /root explicitly to if using docker buildx
-      - HOME=/root
     args:
-    - -c
+      - -c
-    - |
+      - gcloud auth configure-docker && cd images/opentelemetry && make NGINX_VERSION=1.21.6 push && make NGINX_VERSION=1.25.3 push
-      gcloud auth configure-docker \
+timeout: 3600s
-      && cd images/opentelemetry && make NGINX_VERSION=1.25.3 push \
-      && make NGINX_VERSION=1.21.6 push

images/test-runner/cloudbuild.yaml

@@ -1,17 +1,9 @@
-timeout: 3600s
-options:
-  substitution_option: ALLOW_LOOSE
 steps:
-  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90
+  - name: gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240523-a15ad90fc9
-    entrypoint: bash
     env:
-      - DOCKER_CLI_EXPERIMENTAL=enabled
       - REGISTRY=gcr.io/k8s-staging-ingress-nginx
-      # default cloudbuild has HOME=/builder/home and docker buildx is in /root/.docker/cli-plugins/docker-buildx
+    entrypoint: bash
-      # set the home to /root explicitly to if using docker buildx
-      - HOME=/root
     args:
-    - -c
+      - -c
-    - |
+      - gcloud auth configure-docker && cd images/test-runner && make push
-      gcloud auth configure-docker \
+timeout: 1800s
-      && cd images/test-runner && make push