DevFW-CICD/ingress-nginx-helm
14
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #409 from aledbf/http2-headers

Browse source 
Allow custom http2 header sizes
This commit is contained in:
Manuel Alejandro de Brito Fontes 2017-03-08 20:25:25 -03:00 committed by GitHub
commit 1b1e96019a
2 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
controllers/nginx/pkg/config/config.go
View file

@ -121,6 +121,14 @@ type Configuration struct {
// Log levels above are listed in the order of increasing severity // Log levels above are listed in the order of increasing severity
ErrorLogLevel string `json:"error-log-level,omitempty"` ErrorLogLevel string `json:"error-log-level,omitempty"`
// https://nginx.org/en/docs/http/ngx_http_v2_module.html#http2_max_field_size
// HTTP2MaxFieldSize Limits the maximum size of an HPACK-compressed request header field
HTTP2MaxFieldSize string `json:"http2-max-field-size,omitempty"`
// https://nginx.org/en/docs/http/ngx_http_v2_module.html#http2_max_header_size
// HTTP2MaxHeaderSize Limits the maximum size of the entire request header list after HPACK decompression
HTTP2MaxHeaderSize string `json:"http2-max-header-size,omitempty"`
// Enables or disables the header HSTS in servers running SSL // Enables or disables the header HSTS in servers running SSL
HSTS bool `json:"hsts,omitempty"` HSTS bool `json:"hsts,omitempty"`
@ -255,6 +263,8 @@ func NewDefault() Configuration {
DisableIpv6: false, DisableIpv6: false,
EnableDynamicTLSRecords: true, EnableDynamicTLSRecords: true,
ErrorLogLevel: errorLevel, ErrorLogLevel: errorLevel,
HTTP2MaxFieldSize: "4k",
HTTP2MaxHeaderSize: "16k",
HSTS: true, HSTS: true,
HSTSIncludeSubdomains: true, HSTSIncludeSubdomains: true,
HSTSMaxAge: hstsMaxAge, HSTSMaxAge: hstsMaxAge,

4
controllers/nginx/rootfs/etc/nginx/template/nginx.tmpl
View file

@ -60,7 +60,9 @@ http {
client_header_buffer_size {{ $cfg.ClientHeaderBufferSize }}; client_header_buffer_size {{ $cfg.ClientHeaderBufferSize }};
large_client_header_buffers {{ $cfg.LargeClientHeaderBuffers }}; large_client_header_buffers {{ $cfg.LargeClientHeaderBuffers }};
http2_max_field_size {{ $cfg.ClientHeaderBufferSize }};
http2_max_field_size {{ $cfg.HTTP2MaxFieldSize }};
http2_max_header_size {{ $cfg.HTTP2MaxHeaderSize }};
types_hash_max_size 2048; types_hash_max_size 2048;
server_names_hash_max_size {{ $cfg.ServerNameHashMaxSize }}; server_names_hash_max_size {{ $cfg.ServerNameHashMaxSize }};