DevFW-CICD/ingress-nginx-helm
14
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #5409 from rvillablanca/fix/wrong-error-handling

Browse source 
Removed wrong code
This commit is contained in:
Kubernetes Prow Robot 2020-04-20 14:25:40 -07:00 committed by GitHub
commit 2a7c19ca8b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
internal/ingress/controller/controller.go
View file

@ -198,10 +198,6 @@ func (n *NGINXController) syncIngress(interface{}) error {
// CheckIngress returns an error in case the provided ingress, when added // CheckIngress returns an error in case the provided ingress, when added
// to the current configuration, generates an invalid configuration // to the current configuration, generates an invalid configuration
func (n *NGINXController) CheckIngress(ing *networking.Ingress) error { func (n *NGINXController) CheckIngress(ing *networking.Ingress) error {
//TODO: this is wrong
if n == nil {
return fmt.Errorf("cannot check ingress on a nil ingress controller")
}
if ing == nil { if ing == nil {
// no ingress to add, no state change // no ingress to add, no state change