DevFW-CICD/ingress-nginx-helm
15
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Config: Remove notes about future defaults. (#12898)

Browse source 
Signed-off-by: Clément Nussbaumer <clement.nussbaumer@postfinance.ch>
Co-authored-by: Clément Nussbaumer <clement.nussbaumer@postfinance.ch>
This commit is contained in:
k8s-infra-cherrypick-robot 2025-02-24 23:24:29 -08:00 committed by GitHub
parent 700674ba22
commit 2bc331ed82
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
internal/ingress/controller/config/config.go
View file

@ -97,12 +97,10 @@ type Configuration struct {
// AllowCrossNamespaceResources enables users to consume cross namespace resource on annotations // AllowCrossNamespaceResources enables users to consume cross namespace resource on annotations
// Case disabled, attempts to use secrets or configmaps from a namespace different from Ingress will // Case disabled, attempts to use secrets or configmaps from a namespace different from Ingress will
// be denied // be denied
// This value will default to `false` on future releases
AllowCrossNamespaceResources bool `json:"allow-cross-namespace-resources"` AllowCrossNamespaceResources bool `json:"allow-cross-namespace-resources"`
// AnnotationsRiskLevel represents the risk accepted on an annotation. If the risk is, for instance `Medium`, annotations // AnnotationsRiskLevel represents the risk accepted on an annotation. If the risk is, for instance `Medium`, annotations
// with risk High and Critical will not be accepted. // with risk High and Critical will not be accepted.
// Default Risk is Critical by default, but this may be changed in future releases
AnnotationsRiskLevel string `json:"annotations-risk-level"` AnnotationsRiskLevel string `json:"annotations-risk-level"`
// AnnotationValueWordBlocklist defines words that should not be part of an user annotation value // AnnotationValueWordBlocklist defines words that should not be part of an user annotation value

1
internal/ingress/defaults/main.go
View file

@ -185,7 +185,6 @@ type SecurityConfiguration struct {
// AllowCrossNamespaceResources enables users to consume cross namespace resource on annotations // AllowCrossNamespaceResources enables users to consume cross namespace resource on annotations
// Case disabled, attempts to use secrets or configmaps from a namespace different from Ingress will // Case disabled, attempts to use secrets or configmaps from a namespace different from Ingress will
// be denied // be denied
// This valid will default to `false` on future releases
AllowCrossNamespaceResources bool `json:"allow-cross-namespace-resources"` AllowCrossNamespaceResources bool `json:"allow-cross-namespace-resources"`
// AnnotationsRiskLevel represents the risk accepted on an annotation. If the risk is, for instance `Medium`, annotations // AnnotationsRiskLevel represents the risk accepted on an annotation. If the risk is, for instance `Medium`, annotations