From 302cee8319904f8adcfc343932d71c758c1787fd Mon Sep 17 00:00:00 2001 From: Tom Hayward Date: Fri, 19 Apr 2024 07:40:51 -0700 Subject: [PATCH] explain code per review comments --- internal/ingress/controller/nginx.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/internal/ingress/controller/nginx.go b/internal/ingress/controller/nginx.go index d9344d403..e19ee8bb3 100644 --- a/internal/ingress/controller/nginx.go +++ b/internal/ingress/controller/nginx.go @@ -202,6 +202,8 @@ func NewNGINXController(config *Configuration, mc metric.Collector) *NGINXContro } for _, f := range filesToWatch { + // This redeclaration is necessary for the closure to get the correct value for the iteration in go versions <1.22 + // See https://go.dev/blog/loopvar-preview f := f _, err = file.NewFileWatcher(f, func() { klog.InfoS("File change detected. Reloading NGINX", "path", f)