From 34c42f28698dbcabe968ce8abe1014e5ab4b5c51 Mon Sep 17 00:00:00 2001 From: Manuel de Brito Fontes Date: Fri, 20 Jan 2017 19:01:37 -0300 Subject: [PATCH] Add flag to allow switch off the update of Ingress status --- core/pkg/ingress/controller/controller.go | 14 +++++++++----- core/pkg/ingress/controller/launch.go | 4 ++++ 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/core/pkg/ingress/controller/controller.go b/core/pkg/ingress/controller/controller.go index 87cddf59c..3b491d727 100644 --- a/core/pkg/ingress/controller/controller.go +++ b/core/pkg/ingress/controller/controller.go @@ -128,6 +128,8 @@ type Configuration struct { // Backend is the particular implementation to be used. // (for instance NGINX) Backend ingress.Controller + + UpdateStatus bool } // newIngressController creates an Ingress controller @@ -257,11 +259,13 @@ func newIngressController(config *Configuration) *GenericController { cache.ResourceEventHandlerFuncs{}, cache.Indexers{cache.NamespaceIndex: cache.MetaNamespaceIndexFunc}) - ic.syncStatus = status.NewStatusSyncer(status.Config{ - Client: config.Client, - PublishService: ic.cfg.PublishService, - IngressLister: ic.ingLister, - }) + if !config.UpdateStatus { + ic.syncStatus = status.NewStatusSyncer(status.Config{ + Client: config.Client, + PublishService: ic.cfg.PublishService, + IngressLister: ic.ingLister, + }) + } ic.annotations = newAnnotationExtractor(ic) diff --git a/core/pkg/ingress/controller/launch.go b/core/pkg/ingress/controller/launch.go index 95e50c877..eecc9b39e 100644 --- a/core/pkg/ingress/controller/launch.go +++ b/core/pkg/ingress/controller/launch.go @@ -73,6 +73,9 @@ func NewIngressController(backend ingress.Controller) *GenericController { defHealthzURL = flags.String("health-check-path", "/healthz", `Defines the URL to be used as health check inside in the default server in NGINX.`) + + updateStatus = flags.Bool("update-status", true, `Indicates if the + ingress controller should update the Ingress status IP/hostname. Default is true`) ) flags.AddGoFlagSet(flag.CommandLine) @@ -134,6 +137,7 @@ func NewIngressController(backend ingress.Controller) *GenericController { os.MkdirAll(ingress.DefaultSSLDirectory, 0655) config := &Configuration{ + UpdateStatus: *updateStatus, Client: kubeClient, ResyncPeriod: *resyncPeriod, DefaultService: *defaultSvc,