DevFW-CICD/ingress-nginx-helm
16
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove stickyness cookie domain from Lua balancer to match old behavior (#3648)

Browse source
This commit is contained in:
Maximilian Gaß 2019-01-12 02:24:45 +01:00 committed by Manuel Alejandro de Brito Fontes
parent 9f74dc2dd0
commit 39dd0c50da
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
rootfs/etc/nginx/lua/balancer/sticky.lua
View file

@ -52,7 +52,6 @@ local function set_cookie(self, value)
key = self.cookie_name, key = self.cookie_name,
value = value, value = value,
path = cookie_path, path = cookie_path,
domain = ngx.var.host,
httponly = true, httponly = true,
secure = ngx.var.https == "on", secure = ngx.var.https == "on",
} }

4
rootfs/etc/nginx/lua/test/balancer/sticky_test.lua
View file

@ -119,7 +119,7 @@ describe("Sticky", function()
local expected_len = #util[test_backend_hash_fn .. "_digest"]("anything") local expected_len = #util[test_backend_hash_fn .. "_digest"]("anything")
assert.equal(#payload.value, expected_len) assert.equal(#payload.value, expected_len)
assert.equal(payload.path, ngx.var.location_path) assert.equal(payload.path, ngx.var.location_path)
assert.equal(payload.domain, ngx.var.host) assert.equal(payload.domain, nil)
assert.equal(payload.httponly, true) assert.equal(payload.httponly, true)
assert.equal(payload.secure, false) assert.equal(payload.secure, false)
return true, nil return true, nil
@ -148,7 +148,7 @@ describe("Sticky", function()
local expected_len = #util[test_backend_hash_fn .. "_digest"]("anything") local expected_len = #util[test_backend_hash_fn .. "_digest"]("anything")
assert.equal(#payload.value, expected_len) assert.equal(#payload.value, expected_len)
assert.equal(payload.path, ngx.var.location_path) assert.equal(payload.path, ngx.var.location_path)
assert.equal(payload.domain, ngx.var.host) assert.equal(payload.domain, nil)
assert.equal(payload.httponly, true) assert.equal(payload.httponly, true)
assert.equal(payload.secure, true) assert.equal(payload.secure, true)
return true, nil return true, nil