From 47920188a410b7f4a2210f69ce42508ab0961d30 Mon Sep 17 00:00:00 2001
From: suminhong <honglab97@gmail.com>
Date: Thu, 4 Apr 2024 19:21:07 +0900
Subject: [PATCH] add comment & docu

---
 charts/ingress-nginx/README.md   | 2 ++
 charts/ingress-nginx/values.yaml | 7 ++++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/charts/ingress-nginx/README.md b/charts/ingress-nginx/README.md
index e7298b5b7..99412b68f 100644
--- a/charts/ingress-nginx/README.md
+++ b/charts/ingress-nginx/README.md
@@ -425,6 +425,8 @@ As of version `1.26.0` of this chart, by simply not providing any clusterIP valu
 | controller.scope.namespaceSelector | string | `""` | When scope.enabled == false, instead of watching all namespaces, we watching namespaces whose labels only match with namespaceSelector. Format like foo=bar. Defaults to empty, means watching all namespaces. |
 | controller.service.annotations | object | `{}` | Annotations to be added to the external controller service. See `controller.service.internal.annotations` for annotations to be added to the internal controller service. |
 | controller.service.appProtocol | bool | `true` | Declare the app protocol of the external HTTP and HTTPS listeners or not. Supersedes provider-specific annotations for declaring the backend protocol. Ref: https://kubernetes.io/docs/concepts/services-networking/service/#application-protocol |
+| controller.service.awsTargetGroupBinding.enabled | bool | `false` | Declare use an already existing AWS load balancer or not. Even if true, it can only be used when `controller.service.type` is `nodePort`. Ref: https://kubernetes-sigs.github.io/aws-load-balancer-controller/latest/guide/targetgroupbinding/targetgroupbinding/ |
+| controller.service.awsTargetGroupBinding.arnMapping | object | `{}` |  |
 | controller.service.clusterIP | string | `""` | Pre-defined cluster internal IP address of the external controller service. Take care of collisions with existing services. This value is immutable. Set once, it can not be changed without deleting and re-creating the service. Ref: https://kubernetes.io/docs/concepts/services-networking/service/#choosing-your-own-ip-address |
 | controller.service.enableHttp | bool | `true` | Enable the HTTP listener on both controller services or not. |
 | controller.service.enableHttps | bool | `true` | Enable the HTTPS listener on both controller services or not. |
diff --git a/charts/ingress-nginx/values.yaml b/charts/ingress-nginx/values.yaml
index 9fe751402..fb846c6f4 100644
--- a/charts/ingress-nginx/values.yaml
+++ b/charts/ingress-nginx/values.yaml
@@ -546,11 +546,12 @@ controller:
       #   53: 30053
       udp: {}
     # -- If want to use an existing AWS LoadBalancer, write the arn of the Target Group.
+    # controller.service.type: NodePort, and aws-load-balancer-controller must be installed to use.
     awsTargetGroupBinding:
       enabled: false
-      arnMapping:
-        http: ""
-        https: ""
+      arnMapping: {}
+        # http: <arn-to-targetGroup>
+        # https: <arn-to-targetGroup>
     internal:
       # -- Enable the internal controller service or not. Remember to configure `controller.service.internal.annotations` when enabling this.
       enabled: false