From b26e645a0152259132043df9f06ddcae7a42ac73 Mon Sep 17 00:00:00 2001 From: Chen Chen Date: Tue, 11 Jul 2023 14:07:12 +0000 Subject: [PATCH 1/2] Add golint-check entry in makefile Signed-off-by: Chen Chen --- Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Makefile b/Makefile index 7b413141a..fcbbb9f62 100644 --- a/Makefile +++ b/Makefile @@ -128,6 +128,10 @@ static-check: ## Run verification script for boilerplate, codegen, gofmt, golint MAC_OS=$(MAC_OS) \ hack/verify-all.sh +.PHONY: golint-check +golint-check: + hack/verify-golint.sh + ############################### # Tests for ingress-nginx ############################### From 88be7be3ce772a60868a8aaab4b6d043150d0cd8 Mon Sep 17 00:00:00 2001 From: Chen Chen Date: Tue, 11 Jul 2023 14:12:47 +0000 Subject: [PATCH 2/2] Run golint-check in a container Signed-off-by: Chen Chen --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index fcbbb9f62..792cd56a7 100644 --- a/Makefile +++ b/Makefile @@ -130,7 +130,9 @@ static-check: ## Run verification script for boilerplate, codegen, gofmt, golint .PHONY: golint-check golint-check: - hack/verify-golint.sh + @build/run-in-docker.sh \ + MAC_OS=$(MAC_OS) \ + hack/verify-golint.sh ############################### # Tests for ingress-nginx