DevFW-CICD/ingress-nginx-helm
16
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add checker test for bad pid (#2191)

Browse source
This commit is contained in:
Antoine Cotten 2018-03-09 18:21:02 +01:00 committed by Manuel Alejandro de Brito Fontes
parent dbbeffb86c
commit 4a49d67adc
1 changed files with 8 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
internal/ingress/controller/checker_test.go
View file

@ -55,11 +55,11 @@ func TestNginxCheck(t *testing.T) {
t.Run("no pid or process", func(t *testing.T) { t.Run("no pid or process", func(t *testing.T) {
if err := callHealthz(true, mux); err == nil { if err := callHealthz(true, mux); err == nil {
t.Errorf("expected an error but none returned") t.Error("expected an error but none returned")
} }
}) })
// create required files // create pid file
fs.MkdirAll("/run", 0655) fs.MkdirAll("/run", 0655)
pidFile, err := fs.Create("/run/nginx.pid") pidFile, err := fs.Create("/run/nginx.pid")
if err != nil { if err != nil {
@ -68,7 +68,7 @@ func TestNginxCheck(t *testing.T) {
t.Run("no process", func(t *testing.T) { t.Run("no process", func(t *testing.T) {
if err := callHealthz(true, mux); err == nil { if err := callHealthz(true, mux); err == nil {
t.Errorf("expected an error but none returned") t.Error("expected an error but none returned")
} }
}) })
@ -92,23 +92,20 @@ func TestNginxCheck(t *testing.T) {
} }
}) })
pidFile, err = fs.Create("/run/nginx.pid") // pollute pid file
if err != nil { pidFile.Write([]byte(fmt.Sprint("999999")))
t.Fatalf("unexpected error: %v", err)
}
pidFile.Write([]byte(fmt.Sprintf("%v", pid)))
pidFile.Close() pidFile.Close()
t.Run("valid request", func(t *testing.T) { t.Run("bad pid", func(t *testing.T) {
if err := callHealthz(true, mux); err == nil { if err := callHealthz(true, mux); err == nil {
t.Errorf("expected an error but none returned") t.Error("expected an error but none returned")
} }
}) })
t.Run("invalid port", func(t *testing.T) { t.Run("invalid port", func(t *testing.T) {
n.cfg.ListenPorts.Status = 9000 n.cfg.ListenPorts.Status = 9000
if err := callHealthz(true, mux); err == nil { if err := callHealthz(true, mux); err == nil {
t.Errorf("expected an error but none returned") t.Error("expected an error but none returned")
} }
}) })
} }