DevFW-CICD/ingress-nginx-helm
12
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #5388 from rvillablanca/rm-todos

Browse source 
Remove TODO that were done
This commit is contained in:
Kubernetes Prow Robot 2020-04-17 19:59:35 -07:00 committed by GitHub
commit 5b8d4baf5c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
internal/ingress/controller/template/template.go
View file

@ -552,7 +552,6 @@ rewrite "(?i)%s" %s break;
return defProxyPass return defProxyPass
} }
// TODO: Needs Unit Tests
func filterRateLimits(input interface{}) []ratelimit.Config { func filterRateLimits(input interface{}) []ratelimit.Config {
ratelimits := []ratelimit.Config{} ratelimits := []ratelimit.Config{}
found := sets.String{} found := sets.String{}
@ -573,7 +572,6 @@ func filterRateLimits(input interface{}) []ratelimit.Config {
return ratelimits return ratelimits
} }
// TODO: Needs Unit Tests
// buildRateLimitZones produces an array of limit_conn_zone in order to allow // buildRateLimitZones produces an array of limit_conn_zone in order to allow
// rate limiting of request. Each Ingress rule could have up to three zones, one // rate limiting of request. Each Ingress rule could have up to three zones, one
// for connection limit by IP address, one for limiting requests per minute, and // for connection limit by IP address, one for limiting requests per minute, and