review comments

This commit is contained in:
Ehsan Saei 2023-03-21 21:25:46 +01:00 committed by GitHub
parent a1d9aabd98
commit 6b8f0c69ee
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 5 deletions

View file

@ -208,7 +208,7 @@ modsecurity
modules
nginx.conf
opentracing.json
opentelemtry.toml
opentelemetry.toml
owasp-modsecurity-crs
template
```

View file

@ -160,7 +160,7 @@ The following table shows a configuration option's name, type, and the default v
|[enable-opentelemetry](#enable-opentelemetry) |bool |"false" |
|[opentelemetry-trust-incoming-span](#opentelemetry-trust-incoming-span) |bool |"true" |
|[opentelemetry-operation-name](#opentelemetry-operation-name) |string |"" |
|[opentelemetry-config](#/etc/nginx/opentelemtry.toml) |string |"/etc/nginx/opentelemtry.toml" |
|[opentelemetry-config](#/etc/nginx/opentelemetry.toml) |string |"/etc/nginx/opentelemetry.toml" |
|[otlp-collector-host](#otlp-collector-host) |string |"" |
|[otlp-collector-port](#otlp-collector-port) |int |4317 |
|[otel-max-queuesize](#otel-max-queuesize) |int | |

View file

@ -42,7 +42,7 @@ opentelemetry-operation-name
# sets whether or not to trust incoming telemetry spans
opentelemetry-trust-incoming-span
# specifies the port to use when uploading traces, Default: 9411
# specifies the port to use when uploading traces, Default: 4317
otlp-collector-port
# specifies the service name to use for any traces created, Default: nginx
@ -155,7 +155,7 @@ To install the example and collectors run:
enable-opentelemetry: "true"
opentelemetry-config: "/etc/nginx/opentelemetry.toml"
opentelemetry-operation-name: "HTTP $request_method $service_name $uri"
OpentelemetryTrustIncomingSpan: "true"
opentelemetry-trust-incoming-span: "true"
otlp-collector-host: "otel-coll-collector.otel.svc"
otlp-collector-port: "4317"
otel-max-queuesize: "2048"
@ -167,7 +167,7 @@ To install the example and collectors run:
otel-sampler-parent-based: "false"
metadata:
name: ingress-nginx-controller
namespace: kube-system
namespace: ingress-nginx
' | kubectl replace -f -
```