From 6bd97d195f366e29841ad45f05b891b5f421d2ba Mon Sep 17 00:00:00 2001 From: Manuel Alejandro de Brito Fontes Date: Wed, 24 Jan 2018 14:46:43 -0300 Subject: [PATCH] Only secrets in the local store can be updated (#1974) --- internal/ingress/controller/store/store.go | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/internal/ingress/controller/store/store.go b/internal/ingress/controller/store/store.go index 59f476720..8b189c733 100644 --- a/internal/ingress/controller/store/store.go +++ b/internal/ingress/controller/store/store.go @@ -303,19 +303,18 @@ func New(checkOCSP bool, sec := cur.(*apiv1.Secret) key := fmt.Sprintf("%v/%v", sec.Namespace, sec.Name) - _, err := store.GetLocalSecret(k8s.MetaNamespaceKey(sec)) - if err != nil { - glog.Errorf("%v", err) - store.syncSecret(key) - updateCh <- Event{ - Type: UpdateEvent, - Obj: cur, - } - } - // parse the ingress annotations (again) if set, ok := store.secretIngressMap[key]; ok { glog.Infof("secret %v changed and it is used in ingress annotations. Parsing...", key) + _, err := store.GetLocalSecret(k8s.MetaNamespaceKey(sec)) + if err == nil { + store.syncSecret(key) + updateCh <- Event{ + Type: UpdateEvent, + Obj: cur, + } + } + for _, name := range set.List() { ing, _ := store.GetIngress(name) store.extractAnnotations(ing)