From 6ef9a7f023fd9566dc49640697d620d8d259a407 Mon Sep 17 00:00:00 2001 From: Ricardo Katz Date: Sat, 23 Sep 2023 13:45:00 -0300 Subject: [PATCH] Fix release notes on helm (#10434) --- magefiles/steps/helm.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/magefiles/steps/helm.go b/magefiles/steps/helm.go index b4cdc6d81..b53283f78 100644 --- a/magefiles/steps/helm.go +++ b/magefiles/steps/helm.go @@ -20,6 +20,7 @@ import ( "bytes" "fmt" "os" + "strings" semver "github.com/blang/semver/v4" "github.com/helm/helm/pkg/chartutil" @@ -107,10 +108,10 @@ func updateChartReleaseNotes(releasesNotes []string) { utils.Info("HELM Updating the Chart Release notes") chart, err := chartutil.LoadChartfile(HelmChartPath) utils.CheckIfError(err, "HELM Could not Load Chart to update release notes %s", HelmChartPath) - var releaseNoteString string for i := range releasesNotes { - releaseNoteString = fmt.Sprintf("%s - \"%s\"\n", releaseNoteString, releasesNotes[i]) + releasesNotes[i] = fmt.Sprintf("- %q", releasesNotes[i]) } + releaseNoteString := strings.Join(releasesNotes, "\n") utils.Info("HELM Release note string %s", releaseNoteString) chart.Annotations["artifacthub.io/changes"] = releaseNoteString err = chartutil.SaveChartfile(HelmChartPath, chart)