From bda66469053ee38278c20587f8ce167b616c7748 Mon Sep 17 00:00:00 2001 From: Giancarlo Rubio Date: Wed, 14 Dec 2016 17:42:34 +0100 Subject: [PATCH] Fix "invalid port in upstream" on nginx controller --- controllers/nginx/pkg/cmd/controller/metrics.go | 2 +- core/pkg/ingress/controller/controller.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/controllers/nginx/pkg/cmd/controller/metrics.go b/controllers/nginx/pkg/cmd/controller/metrics.go index 8ab86f148..a4e8b562d 100644 --- a/controllers/nginx/pkg/cmd/controller/metrics.go +++ b/controllers/nginx/pkg/cmd/controller/metrics.go @@ -42,7 +42,7 @@ func (em exeMatcher) MatchAndName(nacl common.NameAndCmdline) (bool, string) { func (n *NGINXController) setupMonitor(args []string) { pc, err := newProcessCollector(true, exeMatcher{"nginx", args}) if err != nil { - glog.Fatalf("unexpedted error registering nginx collector: %v", err) + glog.Fatalf("unexpected error registering nginx collector: %v", err) } err = prometheus.Register(pc) if err != nil { diff --git a/core/pkg/ingress/controller/controller.go b/core/pkg/ingress/controller/controller.go index 9afc60c6f..37d324df7 100644 --- a/core/pkg/ingress/controller/controller.go +++ b/core/pkg/ingress/controller/controller.go @@ -982,7 +982,7 @@ func (ic *GenericController) getEndpoints( } // check for invalid port value - if targetPort == -1 { + if targetPort <=0 { continue }