From 87297ade3206cda095d3a841f7330b170774c1ce Mon Sep 17 00:00:00 2001 From: Manuel de Brito Fontes Date: Tue, 12 Apr 2016 23:19:39 -0300 Subject: [PATCH] Check for valid PEM content --- controllers/nginx/nginx/ssl.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/controllers/nginx/nginx/ssl.go b/controllers/nginx/nginx/ssl.go index 65ad0608c..82d192303 100644 --- a/controllers/nginx/nginx/ssl.go +++ b/controllers/nginx/nginx/ssl.go @@ -53,8 +53,10 @@ func (nginx *Manager) CheckSSLCertificate(pemFileName string) ([]string, error) return []string{}, err } - var block *pem.Block - block, _ = pem.Decode(pemCerts) + block, _ := pem.Decode(pemCerts) + if block == nil { + return []string{}, fmt.Errorf("No valid PEM formatted block found") + } cert, err := x509.ParseCertificate(block.Bytes) if err != nil {