From 885cdb2ac15121b9e9dc604077494e0ecb0e53dc Mon Sep 17 00:00:00 2001 From: Andreas Sommer Date: Thu, 21 Nov 2019 10:23:19 +0100 Subject: [PATCH] Fix shellcheck lints in dev-env.sh --- build/dev-env.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/build/dev-env.sh b/build/dev-env.sh index c45cd78cd..f0a42172c 100755 --- a/build/dev-env.sh +++ b/build/dev-env.sh @@ -37,11 +37,12 @@ test $(minikube status | grep -c Running) -ge 2 && $(minikube status | grep -q ' --extra-config=kubelet.sync-frequency=1s \ --extra-config=apiserver.authorization-mode=RBAC +# shellcheck disable=SC2046 eval $(minikube docker-env --shell bash) echo "[dev-env] building container" make build container -docker tag "${REGISTRY}/nginx-ingress-controller-${ARCH}:${TAG}" ${DEV_IMAGE} +docker tag "${REGISTRY}/nginx-ingress-controller-${ARCH}:${TAG}" "${DEV_IMAGE}" # kubectl >= 1.14 includes Kustomize via "apply -k". Makes it easier to use on Linux as well, assuming kubectl installed KUBE_CLIENT_VERSION=$(kubectl version --client --short | awk '{print $3}' | cut -d. -f2) || true @@ -56,7 +57,7 @@ if ! kubectl get namespace "${NAMESPACE}"; then kubectl create namespace "${NAMESPACE}" fi -kubectl get deploy nginx-ingress-controller -n ${NAMESPACE} && kubectl delete deploy nginx-ingress-controller -n ${NAMESPACE} +kubectl get deploy nginx-ingress-controller -n "${NAMESPACE}" && kubectl delete deploy nginx-ingress-controller -n "${NAMESPACE}" ROOT=./deploy/minikube