DevFW-CICD/ingress-nginx-helm
16
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid creating unnecessarily executable files

Browse source
This commit is contained in:
ramikg 2023-06-06 15:19:39 +03:00
parent 712e10d417
commit 8b918804fc
3 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
internal/ingress/controller/checker_test.go
View file

@ -76,7 +76,7 @@ func TestNginxCheck(t *testing.T) {
}) })
// create pid file // create pid file
os.MkdirAll("/tmp/nginx", file.ReadWriteByUser) os.MkdirAll("/tmp/nginx", file.ReadWriteExecuteByUser)
pidFile, err := os.Create(nginx.PID) pidFile, err := os.Create(nginx.PID)
if err != nil { if err != nil {
t.Fatalf("unexpected error: %v", err) t.Fatalf("unexpected error: %v", err)

9
pkg/util/file/filesystem.go
View file

@ -16,5 +16,10 @@ limitations under the License.
package file package file
// ReadWriteByUser defines linux permission to read and write files for the owner user import "syscall"
const ReadWriteByUser = 0700
// Linux read/write/execute file permissions for the owner user
const (
ReadWriteByUser = syscall.S_IRUSR | syscall.S_IWUSR
ReadWriteExecuteByUser = syscall.S_IRWXU
)

2
pkg/util/file/structure.go
View file

@ -47,7 +47,7 @@ func CreateRequiredDirectories() error {
_, err := os.Stat(directory) _, err := os.Stat(directory)
if err != nil { if err != nil {
if os.IsNotExist(err) { if os.IsNotExist(err) {
err = os.MkdirAll(directory, ReadWriteByUser) err = os.MkdirAll(directory, ReadWriteExecuteByUser)
if err != nil { if err != nil {
return fmt.Errorf("creating directory %s: %w", directory, err) return fmt.Errorf("creating directory %s: %w", directory, err)
} }