Merge pull request #3853 from aledbf/remove-authbind

Remove authbind

images/nginx/rootfs/Dockerfile

@@ -30,6 +30,4 @@ RUN ln -sf /dev/stderr /var/log/nginx/error.log
 
 EXPOSE 80 443
 
-ENTRYPOINT [ "/entrypoint.sh" ]
-
 CMD ["nginx", "-g", "daemon off;"]

images/nginx/rootfs/build.sh

@@ -92,7 +92,6 @@ clean-install \
   python \
   luarocks \
   libmaxminddb-dev \
-  authbind \
   dumb-init \
   gdb \
   valgrind \
@@ -630,9 +629,3 @@ for dir in "${writeDirs[@]}"; do
   mkdir -p ${dir};
   chown -R www-data.www-data ${dir};
 done
-
-for value in {1..1023};do
-  touch /etc/authbind/byport/$value
-  chown www-data /etc/authbind/byport/$value
-  chmod 755 /etc/authbind/byport/$value
-done

images/nginx/rootfs/entrypoint.sh

@@ -1,19 +0,0 @@
-#!/usr/bin/dumb-init /bin/bash
-
-# Copyright 2018 The Kubernetes Authors.
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-set -e
-
-authbind --deep $@

internal/ingress/controller/util.go

@@ -83,7 +83,6 @@ const (
 )
 
 var valgrind = []string{
-	"valgrind",
 	"--tool=memcheck",
 	"--leak-check=full",
 	"--show-leak-kinds=all",
@@ -91,21 +90,18 @@ var valgrind = []string{
 }
 
 func nginxExecCommand(args ...string) *exec.Cmd {
-	ngx := os.Getenv("NGINX_BINARY")
-	if ngx == "" {
-		ngx = defBinary
-	}
-
-	cmdArgs := []string{"--deep"}
+	cmdArgs := []string{}
 
 	if os.Getenv("RUN_WITH_VALGRIND") == "true" {
 		cmdArgs = append(cmdArgs, valgrind...)
+		cmdArgs = append(cmdArgs, defBinary, "-c", cfgPath)
+		cmdArgs = append(cmdArgs, args...)
+		return exec.Command("valgrind", cmdArgs...)
 	}
 
-	cmdArgs = append(cmdArgs, ngx, "-c", cfgPath)
+	cmdArgs = append(cmdArgs, "-c", cfgPath)
 	cmdArgs = append(cmdArgs, args...)
-
-	return exec.Command("authbind", cmdArgs...)
+	return exec.Command(defBinary, cmdArgs...)
 }
 
 func nginxTestCommand(cfg string) *exec.Cmd {