Merge pull request #3764 from ElvinEfendi/cleanup-confusing-attribute

delete confusing CustomErrors attribute to make things more explicit

internal/ingress/controller/config/config.go

@@ -721,7 +721,6 @@ type TemplateConfig struct {
 	TCPBackends                []ingress.L4Service
 	UDPBackends                []ingress.L4Service
 	HealthzURI                 string
-	CustomErrors               bool
 	Cfg                        Configuration
 	IsIPV6Enabled              bool
 	IsSSLPassthroughEnabled    bool

internal/ingress/controller/nginx.go

@@ -596,7 +596,6 @@ func (n *NGINXController) OnUpdate(ingressCfg ingress.Configuration) error {
 		Servers:                    ingressCfg.Servers,
 		TCPBackends:                ingressCfg.TCPEndpoints,
 		UDPBackends:                ingressCfg.UDPEndpoints,
-		CustomErrors:               len(cfg.CustomHTTPErrors) > 0,
 		Cfg:                        cfg,
 		IsIPV6Enabled:              n.isIPV6Enabled && !cfg.DisableIpv6,
 		NginxStatusIpv4Whitelist:   cfg.NginxStatusIpv4Whitelist,

rootfs/etc/nginx/template/nginx.tmpl

@@ -418,8 +418,7 @@ http {
 
     ssl_ecdh_curve {{ $cfg.SSLECDHCurve }};
 
-    {{ if .CustomErrors }}
-    # Custom error pages
+    {{ if gt (len $cfg.CustomHTTPErrors) 0 }}
     proxy_intercept_errors on;
     {{ end }}