From 93e006c2cedd3c7836c6edd0a46d71f63fa9d0f5 Mon Sep 17 00:00:00 2001
From: Chen Chen <imchench@gmail.com>
Date: Sun, 10 Sep 2023 21:48:10 +0800
Subject: [PATCH] Fix deferInLoop error (#10387)

Signed-off-by: z1cheng <imchench@gmail.com>
---
 internal/nginx/maxmind.go | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/internal/nginx/maxmind.go b/internal/nginx/maxmind.go
index bd6bc1048..4719a22c1 100644
--- a/internal/nginx/maxmind.go
+++ b/internal/nginx/maxmind.go
@@ -179,20 +179,19 @@ func downloadDatabase(dbName string) error {
 			if !strings.HasSuffix(header.Name, mmdbFile) {
 				continue
 			}
+			return func() error {
+				outFile, err := os.Create(path.Join(geoIPPath, mmdbFile))
+				if err != nil {
+					return err
+				}
 
-			outFile, err := os.Create(path.Join(geoIPPath, mmdbFile))
-			if err != nil {
-				return err
-			}
+				defer outFile.Close()
 
-			//nolint:gocritic // TODO: will fix it on a followup PR
-			defer outFile.Close()
-
-			if _, err := io.CopyN(outFile, tarReader, header.Size); err != nil {
-				return err
-			}
-
-			return nil
+				if _, err := io.CopyN(outFile, tarReader, header.Size); err != nil {
+					return err
+				}
+				return nil
+			}()
 		}
 	}