DevFW-CICD/ingress-nginx-helm
15
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix DNS issues with unresolvable backends with ExternalName (#12951)

Browse source 
Co-authored-by: Neer Friedman <neerfri@gmail.com>
Co-authored-by: Pierre Ozoux <pierre@ozoux.net>
This commit is contained in:
k8s-infra-cherrypick-robot 2025-03-06 15:32:19 -08:00 committed by GitHub
parent 7502f9dc65
commit 97c4a70741
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
rootfs/etc/nginx/lua/balancer.lua
View file

@ -77,8 +77,10 @@ local function resolve_external_names(original_backend)
local endpoints = {}
for _, endpoint in ipairs(backend.endpoints) do
local ips = dns_lookup(endpoint.address)
for _, ip in ipairs(ips) do
table.insert(endpoints, { address = ip, port = endpoint.port })
if #ips ~= 1 or ips[1] ~= endpoint.address then
for _, ip in ipairs(ips) do
table.insert(endpoints, { address = ip, port = endpoint.port })
end
end
end
backend.endpoints = endpoints
@ -104,15 +106,19 @@ local function is_backend_with_external_name(backend)
end
local function sync_backend(backend)
-- We resolve external names before checking if the endpoints are empty
-- because the behavior for resolve_external_names when the name was not
-- resolved is to return an empty table so we set the balancer to nil below
-- see https://github.com/kubernetes/ingress-nginx/pull/10989
if is_backend_with_external_name(backend) then
backend = resolve_external_names(backend)
end
if not backend.endpoints or #backend.endpoints == 0 then
balancers[backend.name] = nil
return
end
if is_backend_with_external_name(backend) then
backend = resolve_external_names(backend)
end
backend.endpoints = format_ipv6_endpoints(backend.endpoints)
local implementation = get_implementation(backend)