From a1c662a9a85a4b314b3c0d1835e2e11e6147b532 Mon Sep 17 00:00:00 2001 From: Bowei Du Date: Fri, 30 Apr 2021 16:55:58 -0700 Subject: [PATCH] Remove usage of codecov.io for the time being MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There was a critical security compromise of the bash script that was being downloaded as part of the coverage build: https://about.codecov.io/security-update/ beginning January 31, 2021, there were periodic, unauthorized alterations of our Bash Uploader script by a third party, which enabled them to potentially export information stored in our users' continuous integration (CI) environments. This information was then sent to a third-party server outside of Codecov’s infrastructure. The Bash Uploader is also used in these related uploaders: Codecov-actions uploader for Github, the Codecov CircleCl Orb, and the Codecov Bitrise Step (together, the “Bash Uploaders”). Therefore, these related uploaders were also impacted by this event. The altered version of the Bash Uploader script could potentially affect: Any credentials, tokens, or keys that our customers were passing through their CI runner that would be accessible when the Bash Uploader script was executed. Any services, datastores, and application code that could be accessed with these credentials, tokens, or keys. The git remote information (URL of the origin repository) of repositories using the Bash Uploaders to upload coverage to Codecov in CI. --- Makefile | 6 ------ README.md | 1 - 2 files changed, 7 deletions(-) diff --git a/Makefile b/Makefile index 9b65eebc5..a260c05d5 100644 --- a/Makefile +++ b/Makefile @@ -137,12 +137,6 @@ print-e2e-suite: e2e-test-binary ## Prints information about the suite of e2e te @build/run-in-docker.sh \ hack/print-e2e-suite.sh -.PHONY: cover -cover: ## Run go coverage unit tests. - @build/cover.sh - echo "Uploading coverage results..." - @curl -s https://codecov.io/bash | bash - .PHONY: vet vet: @go vet $(shell go list ${PKG}/internal/... | grep -v vendor) diff --git a/README.md b/README.md index eab3e6bb0..6a5d7605b 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,6 @@ # NGINX Ingress Controller -[![Coverage Status](https://codecov.io/gh/kubernetes/ingress-nginx/branch/master/graph/badge.svg)](https://codecov.io/gh/kubernetes/ingress-nginx) [![Go Report Card](https://goreportcard.com/badge/github.com/kubernetes/ingress-nginx)](https://goreportcard.com/report/github.com/kubernetes/ingress-nginx) [![GitHub license](https://img.shields.io/github/license/kubernetes/ingress-nginx.svg)](https://github.com/kubernetes/ingress-nginx/blob/master/LICENSE) [![GitHub stars](https://img.shields.io/github/stars/kubernetes/ingress-nginx.svg)](https://github.com/kubernetes/ingress-nginx/stargazers)