From aecc5bac2151d8ef5305de6b91e3adeb4b59a86f Mon Sep 17 00:00:00 2001 From: Alan J Castonguay Date: Fri, 19 Feb 2021 13:38:50 -0500 Subject: [PATCH] NIT: Correct comment re default of server-tokens=false The default value of ShowServerTokens aka server-tokens in the global configmap was changed in commit 87aa96b4680ecc9c3b3c89c647791271184929d9 in 2020-09-17 (release v0.40.0) but one reference was overlooked in this comment. Other documentation, implementation and testcases are all in agreement. Correct the comment to align with others: server-tokens=false. --- internal/ingress/controller/config/config.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/ingress/controller/config/config.go b/internal/ingress/controller/config/config.go index 63bd65aac..0e23ea079 100644 --- a/internal/ingress/controller/config/config.go +++ b/internal/ingress/controller/config/config.go @@ -325,7 +325,7 @@ type Configuration struct { // Enables or disables emitting nginx version in error messages and in the “Server” response header field. // http://nginx.org/en/docs/http/ngx_http_core_module.html#server_tokens - // Default: true + // Default: false ShowServerTokens bool `json:"server-tokens"` // Enabled ciphers list to enabled. The ciphers are specified in the format understood by