DevFW-CICD/ingress-nginx-helm
14
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #2844 from aledbf/fix-latency

Browse source 
Do not allow invalid latency values in metrics
This commit is contained in:
k8s-ci-robot 2018-07-24 08:28:55 -07:00 committed by GitHub
commit bdb5ddc473
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
internal/ingress/metric/collectors/socket.go
View file

@ -236,11 +236,13 @@ func (sc *SocketCollector) handleMessage(msg []byte) {
requestsMetric.Inc() requestsMetric.Inc()
} }
latencyMetric, err := sc.upstreamLatency.GetMetricWith(latencyLabels) if stats.Latency != -1 {
if err != nil { latencyMetric, err := sc.upstreamLatency.GetMetricWith(latencyLabels)
glog.Errorf("Error fetching latency metric: %v", err) if err != nil {
} else { glog.Errorf("Error fetching latency metric: %v", err)
latencyMetric.Observe(stats.Latency) } else {
latencyMetric.Observe(stats.Latency)
}
} }
if stats.RequestTime != -1 { if stats.RequestTime != -1 {