From c21f7ce666ea7847be323605f28e61e48c8a5734 Mon Sep 17 00:00:00 2001 From: Giancarlo Rubio Date: Tue, 4 Apr 2017 13:15:06 +0200 Subject: [PATCH] OverrideFlags was called before parsing arguments (arguments was always empty) correct args order for newStatsCollector --- controllers/nginx/pkg/cmd/controller/nginx.go | 2 +- core/pkg/ingress/controller/launch.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/controllers/nginx/pkg/cmd/controller/nginx.go b/controllers/nginx/pkg/cmd/controller/nginx.go index f8685deee..23bf903bd 100644 --- a/controllers/nginx/pkg/cmd/controller/nginx.go +++ b/controllers/nginx/pkg/cmd/controller/nginx.go @@ -271,7 +271,7 @@ func (n *NGINXController) OverrideFlags(flags *pflag.FlagSet) { } flags.Set("ingress-class", ic) - n.stats = newStatsCollector(ic, wc, n.binary) + n.stats = newStatsCollector(wc, ic, n.binary) } // DefaultIngressClass just return the default ingress class diff --git a/core/pkg/ingress/controller/launch.go b/core/pkg/ingress/controller/launch.go index d532c0653..7f02833c6 100644 --- a/core/pkg/ingress/controller/launch.go +++ b/core/pkg/ingress/controller/launch.go @@ -86,11 +86,11 @@ func NewIngressController(backend ingress.Controller) *GenericController { electionID = flags.String("election-id", "ingress-controller-leader", `Election id to use for status update.`) ) - backend.OverrideFlags(flags) - flags.AddGoFlagSet(flag.CommandLine) flags.Parse(os.Args) + backend.OverrideFlags(flags) + flag.Set("logtostderr", "true") glog.Info(backend.Info())