DevFW-CICD/ingress-nginx-helm
16
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix non tls ingress still able to listen on a https port

Browse source
This commit is contained in:
Deepak Rawte 2023-11-28 11:13:48 +05:30
parent eb1303da02
commit c5cadcc120
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
internal/ingress/controller/template/template.go
View file

@ -1413,6 +1413,12 @@ func buildHTTPSListener(t, s interface{}) string {
return "" return ""
} }
for _, server := range tc.Servers {
if server.Hostname == hostname && server.SSLCert == nil {
return ""
}
}
co := commonListenOptions(&tc, hostname) co := commonListenOptions(&tc, hostname)
addrV4 := []string{""} addrV4 := []string{""}

2
test/e2e/lua/dynamic_certificates.go
View file

@ -62,7 +62,7 @@ var _ = framework.IngressNginxDescribe("[Lua] dynamic certificates", func() {
_, err = f.KubeClientSet.NetworkingV1().Ingresses(f.Namespace).Update(context.TODO(), ing, metav1.UpdateOptions{}) _, err = f.KubeClientSet.NetworkingV1().Ingresses(f.Namespace).Update(context.TODO(), ing, metav1.UpdateOptions{})
assert.Nil(ginkgo.GinkgoT(), err) assert.Nil(ginkgo.GinkgoT(), err)
time.Sleep(waitForLuaSync) time.Sleep(1 * time.Hour)
ensureHTTPSRequest(f, f.GetURL(framework.HTTPS), host, host) ensureHTTPSRequest(f, f.GetURL(framework.HTTPS), host, host)
}) })