From 85a848faaff617b42c84643b0e8ec4a8b10ca3b1 Mon Sep 17 00:00:00 2001 From: Manuel Alejandro de Brito Fontes Date: Mon, 24 Jun 2019 23:47:22 -0400 Subject: [PATCH] Fix misspelled and e2e check --- cmd/plugin/lints/deployment.go | 2 +- cmd/plugin/lints/ingress.go | 2 +- cmd/plugin/util/util.go | 2 +- internal/ingress/controller/store/store.go | 2 +- test/e2e/dbg/main.go | 1 + 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/cmd/plugin/lints/deployment.go b/cmd/plugin/lints/deployment.go index 26e218d66..a1c473f1e 100644 --- a/cmd/plugin/lints/deployment.go +++ b/cmd/plugin/lints/deployment.go @@ -58,7 +58,7 @@ func (lint DeploymentLint) Link() string { return "" } -// GetDeploymentLints retuns all of the lints for ingresses +// GetDeploymentLints returns all of the lints for ingresses func GetDeploymentLints() []DeploymentLint { return []DeploymentLint{ removedFlag("sort-backends", 3655, "0.22.0"), diff --git a/cmd/plugin/lints/ingress.go b/cmd/plugin/lints/ingress.go index bf8a5ff3a..8f712f4aa 100644 --- a/cmd/plugin/lints/ingress.go +++ b/cmd/plugin/lints/ingress.go @@ -58,7 +58,7 @@ func (lint IngressLint) Version() string { return lint.version } -// GetIngressLints retuns all of the lints for ingresses +// GetIngressLints returns all of the lints for ingresses func GetIngressLints() []IngressLint { return []IngressLint{ removedAnnotation("add-base-url", 3174, "0.22.0"), diff --git a/cmd/plugin/util/util.go b/cmd/plugin/util/util.go index 1832fca01..9f2134564 100644 --- a/cmd/plugin/util/util.go +++ b/cmd/plugin/util/util.go @@ -60,7 +60,7 @@ func printOrError(s string, e error) error { return nil } -// ParseVersionString returns the major, minor, and patch numbers of a verison string +// ParseVersionString returns the major, minor, and patch numbers of a version string func ParseVersionString(v string) (int, int, int, error) { parts := versionRegex.FindStringSubmatch(v) diff --git a/internal/ingress/controller/store/store.go b/internal/ingress/controller/store/store.go index 01776e3de..299c74e35 100644 --- a/internal/ingress/controller/store/store.go +++ b/internal/ingress/controller/store/store.go @@ -57,7 +57,7 @@ import ( "k8s.io/ingress-nginx/internal/k8s" ) -// IngressFilterFunc decides if an Ingress should be ommited or not +// IngressFilterFunc decides if an Ingress should be omitted or not type IngressFilterFunc func(*ingress.Ingress) bool // Storer is the interface that wraps the required methods to gather information diff --git a/test/e2e/dbg/main.go b/test/e2e/dbg/main.go index 55dfe3a77..f405ecc76 100644 --- a/test/e2e/dbg/main.go +++ b/test/e2e/dbg/main.go @@ -76,6 +76,7 @@ var _ = framework.IngressNginxDescribe("Debug Tool", func() { getCmd := "/dbg backends get " + backends[0] output, err = f.ExecIngressPod(getCmd) + Expect(err).Should(BeNil()) var f map[string]interface{} unmarshalErr := json.Unmarshal([]byte(output), &f)