DevFW-CICD/ingress-nginx-helm
16
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix lint

Browse source
This commit is contained in:
Chotiwat Chawannakul 2024-02-16 01:56:17 -08:00
parent 8292585bb4
commit c97bcbb8ce
1 changed files with 9 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
test/e2e/settings/ssl_passthrough.go
View file

@ -78,6 +78,7 @@ var _ = framework.IngressNginxDescribe("[Flag] enable-ssl-passthrough", func() {
ginkgo.Context("when handling traffic", func() { ginkgo.Context("when handling traffic", func() {
var tlsConfig *tls.Config var tlsConfig *tls.Config
host := "testpassthrough.com" host := "testpassthrough.com"
url := "https://" + net.JoinHostPort(host, "443")
echoName := "echopass" echoName := "echopass"
secretName := host secretName := host
@ -153,6 +154,7 @@ var _ = framework.IngressNginxDescribe("[Flag] enable-ssl-passthrough", func() {
ginkgo.It("should pass unknown traffic to default backend and handle known traffic", func() { ginkgo.It("should pass unknown traffic to default backend and handle known traffic", func() {
/* This one should not receive traffic as it does not contain passthrough annotation */ /* This one should not receive traffic as it does not contain passthrough annotation */
hostBad := "noannotationnopassthrough.com" hostBad := "noannotationnopassthrough.com"
urlBad := "https://" + net.JoinHostPort(hostBad, "443")
ingBad := f.EnsureIngress(framework.NewSingleIngressWithTLS(hostBad, ingBad := f.EnsureIngress(framework.NewSingleIngressWithTLS(hostBad,
"/", "/",
hostBad, hostBad,
@ -173,34 +175,30 @@ var _ = framework.IngressNginxDescribe("[Flag] enable-ssl-passthrough", func() {
return strings.Contains(server, "listen 442") return strings.Contains(server, "listen 442")
}) })
//nolint:gosec // Ignore the gosec error in testing
f.HTTPTestClientWithTLSConfig(&tls.Config{ServerName: host, InsecureSkipVerify: true}). f.HTTPTestClientWithTLSConfig(&tls.Config{ServerName: host, InsecureSkipVerify: true}).
GET("/"). GET("/").
WithURL("https://"+net.JoinHostPort(host, "443")). WithURL(url).
ForceResolve(f.GetNginxIP(), 443). ForceResolve(f.GetNginxIP(), 443).
Expect(). Expect().
Status(http.StatusOK) Status(http.StatusOK)
//nolint:gosec // Ignore the gosec error in testing
f.HTTPTestClientWithTLSConfig(&tls.Config{ServerName: hostBad, InsecureSkipVerify: true}). f.HTTPTestClientWithTLSConfig(&tls.Config{ServerName: hostBad, InsecureSkipVerify: true}).
GET("/"). GET("/").
WithURL("https://"+net.JoinHostPort(hostBad, "443")). WithURL(urlBad).
ForceResolve(f.GetNginxIP(), 443). ForceResolve(f.GetNginxIP(), 443).
Expect(). Expect().
Status(http.StatusNotFound) Status(http.StatusNotFound)
//nolint:gosec // Ignore the gosec error in testing
f.HTTPTestClientWithTLSConfig(tlsConfig). f.HTTPTestClientWithTLSConfig(tlsConfig).
GET("/"). GET("/").
WithURL("https://"+net.JoinHostPort(host, "443")). WithURL(url).
ForceResolve(f.GetNginxIP(), 443). ForceResolve(f.GetNginxIP(), 443).
Expect(). Expect().
Status(http.StatusOK) Status(http.StatusOK)
//nolint:gosec // Ignore the gosec error in testing
f.HTTPTestClientWithTLSConfig(tlsConfigBad). f.HTTPTestClientWithTLSConfig(tlsConfigBad).
GET("/"). GET("/").
WithURL("https://"+net.JoinHostPort(hostBad, "443")). WithURL(urlBad).
ForceResolve(f.GetNginxIP(), 443). ForceResolve(f.GetNginxIP(), 443).
Expect(). Expect().
Status(http.StatusNotFound) Status(http.StatusNotFound)
@ -222,10 +220,9 @@ var _ = framework.IngressNginxDescribe("[Flag] enable-ssl-passthrough", func() {
ginkgo.It("should handle known traffic without Host header", func() { ginkgo.It("should handle known traffic without Host header", func() {
for i := 0; i < tries; i++ { for i := 0; i < tries; i++ {
//nolint:gosec // Ignore the gosec error in testing
f.HTTPTestClientWithTLSConfig(&tls.Config{ServerName: host, InsecureSkipVerify: true}). f.HTTPTestClientWithTLSConfig(&tls.Config{ServerName: host, InsecureSkipVerify: true}).
GET("/"). GET("/").
WithURL("https://"+net.JoinHostPort(host, "443")). WithURL(url).
ForceResolve(f.GetNginxIP(), 443). ForceResolve(f.GetNginxIP(), 443).
WithDialContextMiddleware(throttleMiddleware). WithDialContextMiddleware(throttleMiddleware).
Expect(). Expect().
@ -235,10 +232,9 @@ var _ = framework.IngressNginxDescribe("[Flag] enable-ssl-passthrough", func() {
ginkgo.It("should handle known traffic with Host header", func() { ginkgo.It("should handle known traffic with Host header", func() {
for i := 0; i < tries; i++ { for i := 0; i < tries; i++ {
//nolint:gosec // Ignore the gosec error in testing
f.HTTPTestClientWithTLSConfig(tlsConfig). f.HTTPTestClientWithTLSConfig(tlsConfig).
GET("/"). GET("/").
WithURL("https://"+net.JoinHostPort(host, "443")). WithURL(url).
WithHeader("Host", host). WithHeader("Host", host).
ForceResolve(f.GetNginxIP(), 443). ForceResolve(f.GetNginxIP(), 443).
WithDialContextMiddleware(throttleMiddleware). WithDialContextMiddleware(throttleMiddleware).
@ -249,10 +245,9 @@ var _ = framework.IngressNginxDescribe("[Flag] enable-ssl-passthrough", func() {
ginkgo.It("should handle insecure traffic with Host header", func() { ginkgo.It("should handle insecure traffic with Host header", func() {
for i := 0; i < tries; i++ { for i := 0; i < tries; i++ {
//nolint:gosec // Ignore the gosec error in testing
f.HTTPTestClientWithTLSConfig(&tls.Config{ServerName: host, InsecureSkipVerify: true}). f.HTTPTestClientWithTLSConfig(&tls.Config{ServerName: host, InsecureSkipVerify: true}).
GET("/"). GET("/").
WithURL("https://"+net.JoinHostPort(host, "443")). WithURL(url).
WithHeader("Host", host). WithHeader("Host", host).
ForceResolve(f.GetNginxIP(), 443). ForceResolve(f.GetNginxIP(), 443).
WithDialContextMiddleware(throttleMiddleware). WithDialContextMiddleware(throttleMiddleware).