diff --git a/controllers/gce/backends/backends.go b/controllers/gce/backends/backends.go index a600364d2..037933436 100644 --- a/controllers/gce/backends/backends.go +++ b/controllers/gce/backends/backends.go @@ -224,11 +224,6 @@ func newBackendService(igs []*compute.InstanceGroup, bm BalancingMode, namedPort } } -func (b *Backends) updateProtocol(bs *compute.BackendService, hcLink string, protocol utils.AppProtocol) (*compute.BackendService, error) { - - return bs, nil -} - // Add will get or create a Backend for the given port. func (b *Backends) Add(p ServicePort) error { // We must track the port even if creating the backend failed, because diff --git a/controllers/gce/controller/utils.go b/controllers/gce/controller/utils.go index d41ed2ff9..05109fa28 100644 --- a/controllers/gce/controller/utils.go +++ b/controllers/gce/controller/utils.go @@ -559,8 +559,8 @@ func (t *GCETranslator) getHTTPProbe(svc api_v1.Service, targetPort intstr.IntOr continue } for _, p := range c.Ports { - if targetPort.Type == intstr.Int && targetPort.IntVal == p.ContainerPort || - targetPort.Type == intstr.String && targetPort.StrVal == p.Name { + if (targetPort.Type == intstr.Int && targetPort.IntVal == p.ContainerPort) || + (targetPort.Type == intstr.String && targetPort.StrVal == p.Name) { readinessProbePort := c.ReadinessProbe.Handler.HTTPGet.Port switch readinessProbePort.Type { diff --git a/controllers/gce/examples/health_checks/README.md b/controllers/gce/examples/health_checks/README.md index 25d2049dc..a2d6e710a 100644 --- a/controllers/gce/examples/health_checks/README.md +++ b/controllers/gce/examples/health_checks/README.md @@ -67,8 +67,6 @@ You can confirm the health check endpoint point it's using one of 2 ways: A few points to note: * The readiness probe must be exposed on the port matching the `servicePort` specified in the Ingress -* The readiness probe cannot have special requirements, like headers or HTTPS +* The readiness probe cannot have special requirements like headers * The probe timeouts are translated to GCE health check timeouts * You must create the pods backing the endpoints with the given readiness probe. This *will not* work if you update the replication controller with a different readiness probe. - - diff --git a/examples/health-checks/gce/README.md b/examples/health-checks/gce/README.md index 25d2049dc..a2d6e710a 100644 --- a/examples/health-checks/gce/README.md +++ b/examples/health-checks/gce/README.md @@ -67,8 +67,6 @@ You can confirm the health check endpoint point it's using one of 2 ways: A few points to note: * The readiness probe must be exposed on the port matching the `servicePort` specified in the Ingress -* The readiness probe cannot have special requirements, like headers or HTTPS +* The readiness probe cannot have special requirements like headers * The probe timeouts are translated to GCE health check timeouts * You must create the pods backing the endpoints with the given readiness probe. This *will not* work if you update the replication controller with a different readiness probe. - -