handle_error_when_executing_diff

Signed-off-by: Guihua Zhu <zhuguihua@cmss.chinamobile.com>
This commit is contained in:
Guihua Zhu 2018-12-12 09:08:02 +08:00
parent 19b3b6be0c
commit d22146f3b0

View file

@ -636,8 +636,10 @@ func (n *NGINXController) OnUpdate(ingressCfg ingress.Configuration) error {
return err
}
// TODO: executing diff can return exit code != 0
diffOutput, _ := exec.Command("diff", "-u", cfgPath, tmpfile.Name()).CombinedOutput()
diffOutput, err := exec.Command("diff", "-u", cfgPath, tmpfile.Name()).CombinedOutput()
if err != nil {
klog.Warningf("Failed to executing diff command: %v", err)
}
klog.Infof("NGINX configuration diff:\n%v", string(diffOutput))