Merge pull request #3960 from Shopify/fix-add-headers-segfault

Fix segfault on reference to nonexistent configmap
This commit is contained in:
Kubernetes Prow Robot 2019-04-04 08:52:53 -07:00 committed by GitHub
commit d3f9fbb8fb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -571,20 +571,20 @@ func (n *NGINXController) OnUpdate(ingressCfg ingress.Configuration) error {
cmap, err := n.store.GetConfigMap(cfg.ProxySetHeaders)
if err != nil {
klog.Warningf("Error reading ConfigMap %q from local store: %v", cfg.ProxySetHeaders, err)
}
} else {
setHeaders = cmap.Data
}
}
addHeaders := map[string]string{}
if cfg.AddHeaders != "" {
cmap, err := n.store.GetConfigMap(cfg.AddHeaders)
if err != nil {
klog.Warningf("Error reading ConfigMap %q from local store: %v", cfg.AddHeaders, err)
}
} else {
addHeaders = cmap.Data
}
}
sslDHParam := ""
if cfg.SSLDHParam != "" {