From d4e6c0dfd802b002b6c033bf4b11cc10d9828d06 Mon Sep 17 00:00:00 2001 From: Elvin Efendi Date: Thu, 31 May 2018 13:46:59 -0400 Subject: [PATCH] access_log should be off for internal /configuration endpoint --- rootfs/etc/nginx/template/nginx.tmpl | 1 + test/e2e/lua/dynamic_configuration.go | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/rootfs/etc/nginx/template/nginx.tmpl b/rootfs/etc/nginx/template/nginx.tmpl index fa1fa49f3..7cae84113 100644 --- a/rootfs/etc/nginx/template/nginx.tmpl +++ b/rootfs/etc/nginx/template/nginx.tmpl @@ -541,6 +541,7 @@ http { {{ if $all.DynamicConfigurationEnabled }} location /configuration { + access_log off; {{ if $cfg.EnableOpentracing }} opentracing off; {{ end }} diff --git a/test/e2e/lua/dynamic_configuration.go b/test/e2e/lua/dynamic_configuration.go index 60d686584..17bad12de 100644 --- a/test/e2e/lua/dynamic_configuration.go +++ b/test/e2e/lua/dynamic_configuration.go @@ -135,7 +135,9 @@ var _ = framework.IngressNginxDescribe("Dynamic Configuration", func() { Expect(log).ToNot(BeEmpty()) By("POSTing new backends to Lua endpoint") - Expect(restOfLogs).To(ContainSubstring("a client request body is buffered to a temporary file")) + // NOTE(elvinefendi) now that we disabled access log for this endpoint we have to find a different way to assert this + // or maybe delete this test completely and just rely on unit testing of Lua middleware? + //Expect(restOfLogs).To(ContainSubstring("a client request body is buffered to a temporary file")) Expect(restOfLogs).ToNot(ContainSubstring("dynamic-configuration: unable to read valid request body")) })