DevFW-CICD/ingress-nginx-helm
16
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Always collect metrics when --metrics-per-host=false

Browse source
This commit is contained in:
Christian Hoffmeister 2019-05-31 10:13:53 +02:00
parent 6ba422aa46
commit d890b9864a
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
docs/user-guide/monitoring.md
View file

@ -83,3 +83,9 @@ The username and password is `admin`
After the login you can import the Grafana dashboard from _https://github.com/kubernetes/ingress-nginx/tree/master/deploy/grafana/dashboards_ After the login you can import the Grafana dashboard from _https://github.com/kubernetes/ingress-nginx/tree/master/deploy/grafana/dashboards_
![Dashboard](../images/grafana.png) ![Dashboard](../images/grafana.png)
## Caveats
### Wildcard ingresses
By default request metrics are labeled with the hostname. When you have a wildcard domain ingress, then there will be no metrics for that ingress (to prevent the metrics from exploding in cardinality). To get metrics in this case you need to run the ingress controller with `--metrics-per-host=false` (you will loose labeling by hostname, but still have labeling by ingress).

4
internal/ingress/metric/collectors/socket.go
View file

@ -221,8 +221,8 @@ func (sc *SocketCollector) handleMessage(msg []byte) {
} }
for _, stats := range statsBatch { for _, stats := range statsBatch {
if !sc.hosts.Has(stats.Host) { if sc.metricsPerHost && !sc.hosts.Has(stats.Host) {
klog.V(3).Infof("skiping metric for host %v that is not being served", stats.Host) klog.V(3).Infof("Skipping metric for host %v that is not being served", stats.Host)
continue continue
} }