From df066518f2340cb071f78c5e8386c0d573b17080 Mon Sep 17 00:00:00 2001 From: Tang Le Date: Fri, 17 Feb 2017 19:11:56 +0800 Subject: [PATCH] We need check content, when cmd failed. Signed-off-by: Tang Le --- controllers/nginx/pkg/template/template.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/controllers/nginx/pkg/template/template.go b/controllers/nginx/pkg/template/template.go index cc21dccac..280b4860c 100644 --- a/controllers/nginx/pkg/template/template.go +++ b/controllers/nginx/pkg/template/template.go @@ -111,7 +111,13 @@ func (t *Template) Write(conf config.TemplateConfig, isValidTemplate func([]byte cmd.Stdout = t.outCmdBuf if err := cmd.Run(); err != nil { glog.Warningf("unexpected error cleaning template: %v", err) - return t.tmplBuf.Bytes(), nil + content := t.tmplBuf.Bytes() + err = isValidTemplate(content) + if err != nil { + return nil, err + } + + return content, nil } content := t.outCmdBuf.Bytes()