From e30bbdfe2c68a06ab827397cbdaf80855f5374b8 Mon Sep 17 00:00:00 2001 From: bprashanth Date: Fri, 23 Sep 2016 14:22:22 -0700 Subject: [PATCH] Don't reconcile health checks after first create. --- controllers/gce/healthchecks/healthchecks.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/controllers/gce/healthchecks/healthchecks.go b/controllers/gce/healthchecks/healthchecks.go index 5d11105c9..8ad22acc1 100644 --- a/controllers/gce/healthchecks/healthchecks.go +++ b/controllers/gce/healthchecks/healthchecks.go @@ -64,13 +64,13 @@ func (h *HealthChecks) Add(port int64) error { return err } } else if wantHC.RequestPath != hc.RequestPath { - // TODO: also compare headers interval etc. - glog.Infof("Updating health check %v, path %v -> %v", name, hc.RequestPath, wantHC.RequestPath) - if err := h.cloud.UpdateHttpHealthCheck(wantHC); err != nil { - return err - } + // TODO: reconcile health checks, and compare headers interval etc. + // Currently Ingress doesn't expose all the health check params + // natively, so some users prefer to hand modify the check. + glog.Infof("Unexpected request path on health check %v, has %v want %v, NOT reconciling", + name, hc.RequestPath, wantHC.RequestPath) } else { - glog.Infof("Health check %v already exists", hc.Name) + glog.Infof("Health check %v already exists and has the expected path %v", hc.Name, hc.RequestPath) } return nil }