DevFW-CICD/ingress-nginx-helm
16
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Be more specific about the type of error to retry on

Browse source
This commit is contained in:
bprashanth 2017-02-08 14:38:51 -08:00
parent 24d9aada11
commit ec75490779
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
controllers/gce/backends/backends.go
View file

@ -175,8 +175,16 @@ func (b *Backends) create(igs []*compute.InstanceGroup, namedPort *compute.Named
PortName: namedPort.Name, PortName: namedPort.Name,
} }
if err := b.cloud.CreateBackendService(backend); err != nil { if err := b.cloud.CreateBackendService(backend); err != nil {
glog.Infof("Error creating backend service with balancing mode %v", bm) // This is probably a failure because we tried to create the backend
errs = append(errs, fmt.Sprintf("%v", err)) // with balancingMode=RATE when there are already backends with
// balancingMode=UTILIZATION. Just ignore it and retry setting
// balancingMode=UTILIZATION (b/35102911).
if utils.IsHTTPErrorCode(err, http.StatusBadRequest) {
glog.Infof("Error creating backend service with balancing mode %v:%v", bm, err)
errs = append(errs, fmt.Sprintf("%v", err))
continue
}
return nil, err
} }
return b.Get(namedPort.Port) return b.Get(namedPort.Port)
} }