From ed30be05bc87db1267ad26d30a414bfa51da09a8 Mon Sep 17 00:00:00 2001 From: "m.nabokikh" Date: Thu, 5 Mar 2020 13:59:30 +0400 Subject: [PATCH] Fix quote function in template to render pointers properly --- internal/ingress/controller/template/template.go | 2 ++ internal/ingress/controller/template/template_test.go | 2 ++ 2 files changed, 4 insertions(+) diff --git a/internal/ingress/controller/template/template.go b/internal/ingress/controller/template/template.go index 7939565c3..1b16f1388 100644 --- a/internal/ingress/controller/template/template.go +++ b/internal/ingress/controller/template/template.go @@ -219,6 +219,8 @@ func quote(input interface{}) string { inputStr = input case fmt.Stringer: inputStr = input.String() + case *string: + inputStr = *input default: inputStr = fmt.Sprintf("%v", input) } diff --git a/internal/ingress/controller/template/template_test.go b/internal/ingress/controller/template/template_test.go index f641960ce..7e32eb188 100644 --- a/internal/ingress/controller/template/template_test.go +++ b/internal/ingress/controller/template/template_test.go @@ -256,10 +256,12 @@ func TestFormatIP(t *testing.T) { } func TestQuote(t *testing.T) { + foo := "foo" cases := map[interface{}]string{ "foo": `"foo"`, "\"foo\"": `"\"foo\""`, "foo\nbar": `"foo\nbar"`, + &foo: `"foo"`, 10: `"10"`, } for input, output := range cases {