DevFW-CICD/ingress-nginx-helm
12
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #3795 from Shopify/optional-be-optional

Browse source 
do not warn when optional annotations arent set
This commit is contained in:
Kubernetes Prow Robot 2019-02-21 14:18:05 -08:00 committed by GitHub
commit fb1df217d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
internal/ingress/annotations/authreq/main.go
View file

@ -146,12 +146,12 @@ func (a authReq) Parse(ing *extensions.Ingress) (interface{}, error) {
// Optional Parameters // Optional Parameters
signIn, err := parser.GetStringAnnotation("auth-signin", ing) signIn, err := parser.GetStringAnnotation("auth-signin", ing)
if err != nil { if err != nil {
klog.Warning("auth-signin annotation is undefined and will not be set") klog.V(3).Infof("auth-signin annotation is undefined and will not be set")
} }
authSnippet, err := parser.GetStringAnnotation("auth-snippet", ing) authSnippet, err := parser.GetStringAnnotation("auth-snippet", ing)
if err != nil { if err != nil {
klog.Warning("auth-snippet annotation is undefined and will not be set") klog.V(3).Infof("auth-snippet annotation is undefined and will not be set")
} }
responseHeaders := []string{} responseHeaders := []string{}