Refactor template to generate the image name

* adapt test cases for extraModules

charts/ingress-nginx/ci/daemonset-extra-modules.yaml

@@ -7,4 +7,5 @@ controller:
     type: ClusterIP
   extraModules:
     - name: opentelemetry
-      image: busybox
+      image:
+        image: busybox

charts/ingress-nginx/ci/deployment-extra-modules-default-container-sec-context.yaml

@@ -9,4 +9,5 @@ controller:
     allowPrivilegeEscalation: false
   extraModules:
     - name: opentelemetry
-      image: busybox
+      image:
+        image: busybox

charts/ingress-nginx/ci/deployment-extra-modules-specific-container-sec-context.yaml

@@ -7,6 +7,7 @@ controller:
     type: ClusterIP
   extraModules:
     - name: opentelemetry
-      image: busybox
+      image:
+        image: busybox
       containerSecurityContext:
         allowPrivilegeEscalation: false

charts/ingress-nginx/ci/deployment-extra-modules.yaml

@@ -7,4 +7,5 @@ controller:
     type: ClusterIP
   extraModules:
     - name: opentelemetry
-      image: busybox
+      image:
+        image: busybox

charts/ingress-nginx/templates/_helpers.tpl

@@ -257,7 +257,7 @@ Extra modules.
 */}}
 {{- define "extraModules" -}}
 - name: {{ .name }}
-  image: {{ printf "%s/%s:%s" .image.registry .image.image .image.tag }}{{ include "ingress-nginx.imageDigest" .image }}
+  image: {{ include "imageName" .image }}{{ include "ingress-nginx.imageDigest" .image }}
   command:
   {{- if .image.distroless }}
     - /init_module
@@ -276,3 +276,16 @@ Extra modules.
     - name: modules
       mountPath: /modules_mount
 {{- end -}}
+
+{{/*
+Image Name with optional registry and tag.
+*/}}
+{{- define "imageName" -}}
+{{- if .registry -}}
+{{- printf "%s/" .registry -}}
+{{- end -}}
+{{- printf "%s" .image -}}
+{{- if .tag -}}
+{{- printf ":%s" .tag -}}
+{{- end -}}
+{{- end -}}