DevFW-CICD/ingress-nginx-helm
12
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Annotations: Allow commas in URLs. (#11886)

Browse source 
Signed-off-by: James Strong <strong.james.e@gmail.com>
Co-authored-by: James Strong <strong.james.e@gmail.com>
This commit is contained in:
k8s-infra-cherrypick-robot 2024-08-26 16:01:36 -07:00 committed by GitHub
parent 8543b71943
commit fc00ca8cfa
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
internal/ingress/annotations/parser/validators.go
View file

@ -44,7 +44,7 @@ var (
alphaNumericChars = `\-\.\_\~a-zA-Z0-9\/:` alphaNumericChars = `\-\.\_\~a-zA-Z0-9\/:`
extendedAlphaNumeric = alphaNumericChars + ", " extendedAlphaNumeric = alphaNumericChars + ", "
regexEnabledChars = regexp.QuoteMeta(`^$[](){}*+?|&=\`) regexEnabledChars = regexp.QuoteMeta(`^$[](){}*+?|&=\`)
urlEnabledChars = regexp.QuoteMeta(`:?&=`) urlEnabledChars = regexp.QuoteMeta(`,:?&=`)
) )
// IsValidRegex checks if the tested string can be used as a regex, but without any weird character. // IsValidRegex checks if the tested string can be used as a regex, but without any weird character.

5
internal/ingress/annotations/parser/validators_test.go
View file

@ -55,6 +55,11 @@ func TestValidateArrayOfServerName(t *testing.T) {
value: "*.so*mething.com,bla.com", value: "*.so*mething.com,bla.com",
wantErr: false, wantErr: false,
}, },
{
name: "should allow comma separated query params",
value: "https://oauth.example/oauth2/auth?allowed_groups=gid1,gid2",
wantErr: false,
},
{ {
name: "should deny names with weird characters", name: "should deny names with weird characters",
value: "something.com,lolo;xpto.com,nothing.com", value: "something.com,lolo;xpto.com,nothing.com",