DevFW-CICD/ingress-nginx-helm

Fork 0

Commit graph

Author	SHA1	Message	Date
motoki317	ae42b6aeaa	fix: We do not need to account for readinessProbe requests since the probe is handled within ingress-nginx-controller and does not reach nginx process.	2024-11-28 11:57:31 +09:00
motoki317	872d64b05c	Fix lint issues	2024-11-28 11:57:31 +09:00
motoki317	25f5d09ec0	Improve shutdown logic: wait until no requests are made Pods in Kubernetes endpoints are expected to shut-down 'gracefully' after receiving SIGTERM - we should keep accepting new connections for a while. This is because Kubernetes updates Service endpoints and sends SIGTERM to pods in parallel. See https://github.com/kubernetes/kubernetes/issues/106476 for more detail.	2024-11-28 11:57:31 +09:00

Author

SHA1

Message

Date

motoki317

ae42b6aeaa

fix: We do not need to account for readinessProbe requests

since the probe is handled within ingress-nginx-controller and
does not reach nginx process.

2024-11-28 11:57:31 +09:00

motoki317

872d64b05c

Fix lint issues

2024-11-28 11:57:31 +09:00

motoki317

25f5d09ec0

Improve shutdown logic: wait until no requests are made

Pods in Kubernetes endpoints are expected to shut-down 'gracefully' after receiving SIGTERM -
we should keep accepting new connections for a while. This is because Kubernetes updates Service endpoints
and sends SIGTERM to pods *in parallel*.

See https://github.com/kubernetes/kubernetes/issues/106476 for more detail.

2024-11-28 11:57:31 +09:00

3 commits