/* Copyright 2015 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package authreq import ( "fmt" "net/url" "reflect" "testing" api "k8s.io/api/core/v1" extensions "k8s.io/api/extensions/v1beta1" meta_v1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/ingress-nginx/internal/ingress/annotations/parser" "k8s.io/ingress-nginx/internal/ingress/resolver" "k8s.io/apimachinery/pkg/util/intstr" ) func buildIngress() *extensions.Ingress { defaultBackend := extensions.IngressBackend{ ServiceName: "default-backend", ServicePort: intstr.FromInt(80), } return &extensions.Ingress{ ObjectMeta: meta_v1.ObjectMeta{ Name: "foo", Namespace: api.NamespaceDefault, }, Spec: extensions.IngressSpec{ Backend: &extensions.IngressBackend{ ServiceName: "default-backend", ServicePort: intstr.FromInt(80), }, Rules: []extensions.IngressRule{ { Host: "foo.bar.com", IngressRuleValue: extensions.IngressRuleValue{ HTTP: &extensions.HTTPIngressRuleValue{ Paths: []extensions.HTTPIngressPath{ { Path: "/foo", Backend: defaultBackend, }, }, }, }, }, }, }, } } func TestAnnotations(t *testing.T) { ing := buildIngress() data := map[string]string{} ing.SetAnnotations(data) tests := []struct { title string url string signinURL string method string requestRedirect string authSnippet string expErr bool }{ {"empty", "", "", "", "", "", true}, {"no scheme", "bar", "bar", "", "", "", true}, {"invalid host", "http://", "http://", "", "", "", true}, {"invalid host (multiple dots)", "http://foo..bar.com", "http://foo..bar.com", "", "", "", true}, {"valid URL", "http://bar.foo.com/external-auth", "http://bar.foo.com/external-auth", "", "", "", false}, {"valid URL - send body", "http://foo.com/external-auth", "http://foo.com/external-auth", "POST", "", "", false}, {"valid URL - send body", "http://foo.com/external-auth", "http://foo.com/external-auth", "GET", "", "", false}, {"valid URL - request redirect", "http://foo.com/external-auth", "http://foo.com/external-auth", "GET", "http://foo.com/redirect-me", "", false}, {"auth snippet", "http://foo.com/external-auth", "http://foo.com/external-auth", "", "", "proxy_set_header My-Custom-Header 42;", false}, } for _, test := range tests { data[parser.GetAnnotationWithPrefix("auth-url")] = test.url data[parser.GetAnnotationWithPrefix("auth-signin")] = test.signinURL data[parser.GetAnnotationWithPrefix("auth-method")] = fmt.Sprintf("%v", test.method) data[parser.GetAnnotationWithPrefix("auth-request-redirect")] = test.requestRedirect data[parser.GetAnnotationWithPrefix("auth-snippet")] = test.authSnippet i, err := NewParser(&resolver.Mock{}).Parse(ing) if test.expErr { if err == nil { t.Errorf("%v: expected error but returned nil", test.title) } continue } if err != nil { t.Errorf("%v: unexpected error: %v", test.title, err) } u, ok := i.(*Config) if !ok { t.Errorf("%v: expected an External type", test.title) } if u.URL != test.url { t.Errorf("%v: expected \"%v\" but \"%v\" was returned", test.title, test.url, u.URL) } if u.SigninURL != test.signinURL { t.Errorf("%v: expected \"%v\" but \"%v\" was returned", test.title, test.signinURL, u.SigninURL) } if u.Method != test.method { t.Errorf("%v: expected \"%v\" but \"%v\" was returned", test.title, test.method, u.Method) } if u.RequestRedirect != test.requestRedirect { t.Errorf("%v: expected \"%v\" but \"%v\" was returned", test.title, test.requestRedirect, u.RequestRedirect) } if u.AuthSnippet != test.authSnippet { t.Errorf("%v: expected \"%v\" but \"%v\" was returned", test.title, test.authSnippet, u.AuthSnippet) } } } func TestHeaderAnnotations(t *testing.T) { ing := buildIngress() data := map[string]string{} ing.SetAnnotations(data) tests := []struct { title string url string headers string parsedHeaders []string expErr bool }{ {"single header", "http://goog.url", "h1", []string{"h1"}, false}, {"nothing", "http://goog.url", "", []string{}, false}, {"spaces", "http://goog.url", " ", []string{}, false}, {"two headers", "http://goog.url", "1,2", []string{"1", "2"}, false}, {"two headers and empty entries", "http://goog.url", ",1,,2,", []string{"1", "2"}, false}, {"header with spaces", "http://goog.url", "1 2", []string{}, true}, {"header with other bad symbols", "http://goog.url", "1+2", []string{}, true}, } for _, test := range tests { data[parser.GetAnnotationWithPrefix("auth-url")] = test.url data[parser.GetAnnotationWithPrefix("auth-response-headers")] = test.headers data[parser.GetAnnotationWithPrefix("auth-method")] = "GET" i, err := NewParser(&resolver.Mock{}).Parse(ing) if test.expErr { if err == nil { t.Errorf("%v: expected error but retuned nil", err.Error()) } continue } t.Log(i) u, ok := i.(*Config) if !ok { t.Errorf("%v: expected an External type", test.title) continue } if !reflect.DeepEqual(u.ResponseHeaders, test.parsedHeaders) { t.Errorf("%v: expected \"%v\" but \"%v\" was returned", test.title, test.headers, u.ResponseHeaders) } } } func TestParseStringToURL(t *testing.T) { validURL := "http://bar.foo.com/external-auth" validParsedURL, _ := url.Parse(validURL) tests := []struct { title string url string message string parsed *url.URL expErr bool }{ {"empty", "", "url scheme is empty.", nil, true}, {"no scheme", "bar", "url scheme is empty.", nil, true}, {"invalid host", "http://", "url host is empty.", nil, true}, {"invalid host (multiple dots)", "http://foo..bar.com", "invalid url host.", nil, true}, {"valid URL", validURL, "", validParsedURL, false}, } for _, test := range tests { i, err := ParseStringToURL(test.url) if test.expErr { if err != test.message { t.Errorf("%v: expected error \"%v\" but \"%v\" was returned", test.title, test.message, err) } continue } if i.String() != test.parsed.String() { t.Errorf("%v: expected \"%v\" but \"%v\" was returned", test.title, test.parsed, i) } } }