6807537a70
* upgrade go 1.21.5 Signed-off-by: James Strong <strong.james.e@gmail.com> * update golang gha Signed-off-by: James Strong <strong.james.e@gmail.com> * supgrade golang lint ci to v1.55.2 * sfix all golang lint ci errors * sget a nginx build as well * srevert some e2e changes * srevert some e2e changes --------- Signed-off-by: James Strong <strong.james.e@gmail.com>
114 lines
3.9 KiB
Go
114 lines
3.9 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package settings
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"strings"
|
|
|
|
"github.com/onsi/ginkgo/v2"
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"k8s.io/ingress-nginx/test/e2e/framework"
|
|
)
|
|
|
|
var _ = framework.DescribeSetting("enable-real-ip", func() {
|
|
f := framework.NewDefaultFramework("enable-real-ip")
|
|
|
|
setting := "enable-real-ip"
|
|
|
|
ginkgo.BeforeEach(func() {
|
|
f.NewEchoDeployment()
|
|
f.UpdateNginxConfigMapData(setting, "false")
|
|
})
|
|
|
|
ginkgo.It("trusts X-Forwarded-For header only when setting is true", func() {
|
|
host := "forwarded-for-header"
|
|
|
|
f.UpdateNginxConfigMapData(setting, "true")
|
|
|
|
ing := framework.NewSingleIngress(host, "/", host, f.Namespace, framework.EchoService, 80, nil)
|
|
f.EnsureIngress(ing)
|
|
|
|
f.WaitForNginxServer(host,
|
|
func(server string) bool {
|
|
//nolint:goconst //already a const
|
|
return strings.Contains(server, "server_name "+host) &&
|
|
!strings.Contains(server, "proxy_set_header X-Forwarded-Proto $full_x_forwarded_proto;")
|
|
})
|
|
|
|
ginkgo.By("ensuring single values are parsed correctly")
|
|
body := f.HTTPTestClient().
|
|
GET("/").
|
|
WithHeader("Host", host).
|
|
WithHeader("X-Forwarded-Port", "1234").
|
|
WithHeader("X-Forwarded-Proto", "myproto").
|
|
WithHeader("X-Forwarded-For", "1.2.3.4").
|
|
WithHeader("X-Forwarded-Host", "myhost").
|
|
Expect().
|
|
Status(http.StatusOK).
|
|
Body().
|
|
Raw()
|
|
|
|
assert.NotContains(ginkgo.GinkgoT(), body, "host=myhost")
|
|
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-host=myhost")
|
|
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-proto=myproto")
|
|
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-port=1234")
|
|
assert.Contains(ginkgo.GinkgoT(), body, fmt.Sprintf("host=%s", host))
|
|
assert.Contains(ginkgo.GinkgoT(), body, fmt.Sprintf("x-forwarded-host=%s", host))
|
|
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-proto=http")
|
|
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-port=80")
|
|
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-for=1.2.3.4")
|
|
})
|
|
|
|
ginkgo.It("should not trust X-Forwarded-For header when setting is false", func() {
|
|
host := "forwarded-for-header"
|
|
|
|
f.UpdateNginxConfigMapData(setting, "false")
|
|
|
|
f.EnsureIngress(framework.NewSingleIngress(host, "/", host, f.Namespace, framework.EchoService, 80, nil))
|
|
|
|
f.WaitForNginxServer(host,
|
|
func(server string) bool {
|
|
return strings.Contains(server, "server_name "+host) &&
|
|
strings.Contains(server, "proxy_set_header X-Forwarded-Proto $pass_access_scheme;")
|
|
})
|
|
|
|
body := f.HTTPTestClient().
|
|
GET("/").
|
|
WithHeader("Host", host).
|
|
WithHeader("X-Forwarded-Port", "1234").
|
|
WithHeader("X-Forwarded-Proto", "myproto").
|
|
WithHeader("X-Forwarded-For", "1.2.3.4").
|
|
WithHeader("X-Forwarded-Host", "myhost").
|
|
Expect().
|
|
Status(http.StatusOK).
|
|
Body().
|
|
Raw()
|
|
|
|
assert.Contains(ginkgo.GinkgoT(), body, fmt.Sprintf("host=%s", host))
|
|
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-port=80")
|
|
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-proto=http")
|
|
assert.Contains(ginkgo.GinkgoT(), body, "x-original-forwarded-for=1.2.3.4")
|
|
assert.NotContains(ginkgo.GinkgoT(), body, "host=myhost")
|
|
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-host=myhost")
|
|
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-proto=myproto")
|
|
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-port=1234")
|
|
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-for=1.2.3.4")
|
|
})
|
|
})
|