b3060bfbd0
* Fix golangci-lint errors Signed-off-by: z1cheng <imchench@gmail.com> * Fix dupl errors Signed-off-by: z1cheng <imchench@gmail.com> * Fix comments Signed-off-by: z1cheng <imchench@gmail.com> * Fix errcheck lint errors Signed-off-by: z1cheng <imchench@gmail.com> * Fix assert in e2e test Signed-off-by: z1cheng <imchench@gmail.com> * Not interrupt the waitForPodsReady Signed-off-by: z1cheng <imchench@gmail.com> * Replace string with constant Signed-off-by: z1cheng <imchench@gmail.com> * Fix comments Signed-off-by: z1cheng <imchench@gmail.com> * Revert write file permision Signed-off-by: z1cheng <imchench@gmail.com> --------- Signed-off-by: z1cheng <imchench@gmail.com>
112 lines
2.8 KiB
Go
112 lines
2.8 KiB
Go
/*
|
|
Copyright 2019 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package lints
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
|
|
v1 "k8s.io/api/apps/v1"
|
|
kmeta "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/ingress-nginx/cmd/plugin/util"
|
|
)
|
|
|
|
// DeploymentLint is a validation for a deployment
|
|
type DeploymentLint struct {
|
|
message string
|
|
version string
|
|
issue int
|
|
f func(cmp v1.Deployment) bool
|
|
}
|
|
|
|
// Check returns true if the lint detects an issue
|
|
func (lint DeploymentLint) Check(obj kmeta.Object) bool {
|
|
cmp, ok := obj.(*v1.Deployment)
|
|
if !ok {
|
|
util.PrintError(fmt.Errorf("unexpected type: %T", obj))
|
|
}
|
|
return lint.f(*cmp)
|
|
}
|
|
|
|
// Message is a description of the lint
|
|
func (lint DeploymentLint) Message() string {
|
|
return lint.message
|
|
}
|
|
|
|
// Version is the ingress-nginx version the lint was added for, or the empty string
|
|
func (lint DeploymentLint) Version() string {
|
|
return lint.version
|
|
}
|
|
|
|
// Link is a URL to the issue or PR explaining the lint
|
|
func (lint DeploymentLint) Link() string {
|
|
if lint.issue > 0 {
|
|
return fmt.Sprintf("%v%v", util.IssuePrefix, lint.issue)
|
|
}
|
|
|
|
return ""
|
|
}
|
|
|
|
// GetDeploymentLints returns all of the lints for ingresses
|
|
func GetDeploymentLints() []DeploymentLint {
|
|
return []DeploymentLint{
|
|
removedFlag("sort-backends", 3655, "0.22.0"),
|
|
removedFlag("force-namespace-isolation", 3887, "0.24.0"),
|
|
}
|
|
}
|
|
|
|
func removedFlag(flag string, issueNumber int, version string) DeploymentLint {
|
|
return DeploymentLint{
|
|
message: fmt.Sprintf("Uses removed config flag --%v", flag),
|
|
issue: issueNumber,
|
|
version: version,
|
|
f: func(dep v1.Deployment) bool {
|
|
if !isIngressNginxDeployment(&dep) {
|
|
return false
|
|
}
|
|
|
|
args := getNginxArgs(&dep)
|
|
for _, arg := range args {
|
|
if strings.HasPrefix(arg, fmt.Sprintf("--%v", flag)) {
|
|
return true
|
|
}
|
|
}
|
|
|
|
return false
|
|
},
|
|
}
|
|
}
|
|
|
|
func getNginxArgs(dep *v1.Deployment) []string {
|
|
for i := range dep.Spec.Template.Spec.Containers {
|
|
container := &dep.Spec.Template.Spec.Containers[i]
|
|
if len(container.Args) > 0 && container.Args[0] == "/nginx-ingress-controller" {
|
|
return container.Args
|
|
}
|
|
}
|
|
return make([]string, 0)
|
|
}
|
|
|
|
func isIngressNginxDeployment(dep *v1.Deployment) bool {
|
|
containers := dep.Spec.Template.Spec.Containers
|
|
for i := range containers {
|
|
if len(containers[i].Args) > 0 && containers[i].Args[0] == "/nginx-ingress-controller" {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|