
* images/kube-webhook-certgen/rootfs/pkg/k8s: return err from functions Initially only from some to preserve existing behavior. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com> * images/kube-webhook-certgen/rootfs: make patching return error So we don't call log.Fatal in so many places, which makes code testable. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com> * images/kube-webhook-certgen/rootfs/pkg/k8s: require context So initialize top-level contexts in tests and CLI, then pass them around all the way down, so there is an ability e.g. to add timeouts to patch operations, if needed and to follow general conventions. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com> * images/kube-webhook-certgen/rootfs/pkg/k8s: support patching APIService APIService object is very similar to MutatingWebhookConfiguration and ValidatingWebhookConfiguration objects, so support for patching it shouldn't be too much of a burden. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com> * images/kube-webhook-certgen/rootfs/cmd: use new patch API So old function PatchWebhookConfigurations can be unexported and CLI can be extended to also support patching APIService. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com> * images/kube-webhook-certgen/rootfs/pkg/k8s: unexport old patch function PatchObjects should be now used instead. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com> * images/kube-webhook-certgen/rootfs: add .gitignore To ignore manually built binaries during development process. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com> * images/kube-webhook-certgen/rootfs/cmd: test patching By adding a PatchConfig and Patch function, it is now possible to test logic of flag validation, which was previously tied to CLI options. This commit adds nice set of tests covering existing logic. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com> * images/kube-webhook-certgen/rootfs/cmd: improve formatting Those strings will be changed anyway in future commits, so at first we can properly capitalize used names. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com> * images/kube-webhook-certgen/rootfs/cmd: support patching APIService As logic for creating a CA certificate and patching an object is almost the same for both webhook configuration and API services, this commit adds support to kube-webhook-certgen CLI to also patch APIService objects, so they can be served over TLS as well. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com> * images/kube-webhook-certgen/rootfs: pass failure policy by value k8s.k8s.patchWebhookConfigurations() always dereferences it and we do not do a nil check, so the code may panic in some conditions, so it's safer to just pass it by value, as it's just a wrapped string. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
200 lines
5.6 KiB
Go
200 lines
5.6 KiB
Go
package k8s
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"errors"
|
|
"math/rand"
|
|
"testing"
|
|
|
|
admissionv1 "k8s.io/api/admissionregistration/v1"
|
|
v1 "k8s.io/api/core/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/client-go/kubernetes/fake"
|
|
)
|
|
|
|
const (
|
|
testWebhookName = "c7c95710-d8c3-4cc3-a2a8-8d2b46909c76"
|
|
testSecretName = "15906410-af2a-4f9b-8a2d-c08ffdd5e129"
|
|
testNamespace = "7cad5f92-c0d5-4bc9-87a3-6f44d5a5619d"
|
|
)
|
|
|
|
var (
|
|
fail = admissionv1.Fail
|
|
ignore = admissionv1.Ignore
|
|
)
|
|
|
|
func genSecretData() (ca, cert, key []byte) {
|
|
ca = make([]byte, 4)
|
|
cert = make([]byte, 4)
|
|
key = make([]byte, 4)
|
|
rand.Read(cert)
|
|
rand.Read(key)
|
|
return
|
|
}
|
|
|
|
func newTestSimpleK8s() *k8s {
|
|
return &k8s{
|
|
clientset: fake.NewSimpleClientset(),
|
|
}
|
|
}
|
|
|
|
func TestGetCaFromCertificate(t *testing.T) {
|
|
k := newTestSimpleK8s()
|
|
|
|
ca, cert, key := genSecretData()
|
|
|
|
secret := &v1.Secret{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: testSecretName,
|
|
},
|
|
Data: map[string][]byte{"ca": ca, "cert": cert, "key": key},
|
|
}
|
|
|
|
k.clientset.CoreV1().Secrets(testNamespace).Create(context.Background(), secret, metav1.CreateOptions{})
|
|
|
|
retrievedCa := k.GetCaFromSecret(context.TODO(), testSecretName, testNamespace)
|
|
if !bytes.Equal(retrievedCa, ca) {
|
|
t.Error("Was not able to retrieve CA information that was saved")
|
|
}
|
|
}
|
|
|
|
func TestSaveCertsToSecret(t *testing.T) {
|
|
k := newTestSimpleK8s()
|
|
|
|
ca, cert, key := genSecretData()
|
|
|
|
k.SaveCertsToSecret(context.TODO(), testSecretName, testNamespace, "cert", "key", ca, cert, key)
|
|
|
|
secret, _ := k.clientset.CoreV1().Secrets(testNamespace).Get(context.Background(), testSecretName, metav1.GetOptions{})
|
|
|
|
if !bytes.Equal(secret.Data["cert"], cert) {
|
|
t.Error("'cert' saved data does not match retrieved")
|
|
}
|
|
|
|
if !bytes.Equal(secret.Data["key"], key) {
|
|
t.Error("'key' saved data does not match retrieved")
|
|
}
|
|
}
|
|
|
|
func TestSaveThenLoadSecret(t *testing.T) {
|
|
k := newTestSimpleK8s()
|
|
ca, cert, key := genSecretData()
|
|
ctx := context.TODO()
|
|
k.SaveCertsToSecret(ctx, testSecretName, testNamespace, "cert", "key", ca, cert, key)
|
|
retrievedCert := k.GetCaFromSecret(ctx, testSecretName, testNamespace)
|
|
if !bytes.Equal(retrievedCert, ca) {
|
|
t.Error("Was not able to retrieve CA information that was saved")
|
|
}
|
|
}
|
|
|
|
func TestPatchWebhookConfigurations(t *testing.T) {
|
|
k := newTestSimpleK8s()
|
|
|
|
ca, _, _ := genSecretData()
|
|
|
|
k.clientset.
|
|
AdmissionregistrationV1().
|
|
MutatingWebhookConfigurations().
|
|
Create(context.Background(), &admissionv1.MutatingWebhookConfiguration{
|
|
TypeMeta: metav1.TypeMeta{},
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: testWebhookName,
|
|
},
|
|
Webhooks: []admissionv1.MutatingWebhook{{Name: "m1"}, {Name: "m2"}},
|
|
}, metav1.CreateOptions{})
|
|
|
|
k.clientset.
|
|
AdmissionregistrationV1().
|
|
ValidatingWebhookConfigurations().
|
|
Create(context.Background(), &admissionv1.ValidatingWebhookConfiguration{
|
|
TypeMeta: metav1.TypeMeta{},
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: testWebhookName,
|
|
},
|
|
Webhooks: []admissionv1.ValidatingWebhook{{Name: "v1"}, {Name: "v2"}},
|
|
}, metav1.CreateOptions{})
|
|
|
|
if err := k.patchWebhookConfigurations(context.TODO(), testWebhookName, ca, fail, true, true); err != nil {
|
|
t.Fatalf("Unexpected error patching webhooks: %s: %v", err.Error(), errors.Unwrap(err))
|
|
}
|
|
|
|
whmut, err := k.clientset.
|
|
AdmissionregistrationV1().
|
|
MutatingWebhookConfigurations().
|
|
Get(context.Background(), testWebhookName, metav1.GetOptions{})
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
whval, err := k.clientset.
|
|
AdmissionregistrationV1().
|
|
MutatingWebhookConfigurations().
|
|
Get(context.Background(), testWebhookName, metav1.GetOptions{})
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
if !bytes.Equal(whmut.Webhooks[0].ClientConfig.CABundle, ca) {
|
|
t.Error("Ca retrieved from first mutating webhook configuration does not match")
|
|
}
|
|
if !bytes.Equal(whmut.Webhooks[1].ClientConfig.CABundle, ca) {
|
|
t.Error("Ca retrieved from second mutating webhook configuration does not match")
|
|
}
|
|
if !bytes.Equal(whval.Webhooks[0].ClientConfig.CABundle, ca) {
|
|
t.Error("Ca retrieved from first validating webhook configuration does not match")
|
|
}
|
|
if !bytes.Equal(whval.Webhooks[1].ClientConfig.CABundle, ca) {
|
|
t.Error("Ca retrieved from second validating webhook configuration does not match")
|
|
}
|
|
if whmut.Webhooks[0].FailurePolicy == nil {
|
|
t.Errorf("Expected first mutating webhook failure policy to be set to %s", fail)
|
|
}
|
|
if whmut.Webhooks[1].FailurePolicy == nil {
|
|
t.Errorf("Expected second mutating webhook failure policy to be set to %s", fail)
|
|
}
|
|
if whval.Webhooks[0].FailurePolicy == nil {
|
|
t.Errorf("Expected first validating webhook failure policy to be set to %s", fail)
|
|
}
|
|
if whval.Webhooks[1].FailurePolicy == nil {
|
|
t.Errorf("Expected second validating webhook failure policy to be set to %s", fail)
|
|
}
|
|
}
|
|
|
|
func Test_Patching_objects(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
t.Run("returns_error_when", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
t.Run("failure_policy_is_defined_but_no_webhooks_will_be_patched", func(t *testing.T) {
|
|
t.Parallel()
|
|
})
|
|
|
|
// This is to preserve old behavior and log format, it could be improved.
|
|
t.Run("diffent_names_are_specified_for_validating_and_mutating_webhook", func(t *testing.T) {
|
|
t.Parallel()
|
|
})
|
|
|
|
t.Run("patching_APIService_is_requested_and_it_does_not_exist", func(t *testing.T) {
|
|
t.Parallel()
|
|
})
|
|
|
|
t.Run("patching_webhook_is_requested_and_it_does_not_exist", func(t *testing.T) {
|
|
t.Parallel()
|
|
})
|
|
})
|
|
|
|
t.Run("when_patching_APIService_object", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// This is required when CABundle field is populated.
|
|
t.Run("sets_insecure_skip_tls_verity_to_false", func(t *testing.T) {
|
|
t.Parallel()
|
|
})
|
|
|
|
t.Run("sets_ca_bundle_with_ca_certificate_from_created_secret", func(t *testing.T) {
|
|
t.Parallel()
|
|
})
|
|
})
|
|
}
|