From 5bc54c8341d5b6bda6efe430e6a16c6f27e7fdeb Mon Sep 17 00:00:00 2001 From: Abhijay Kumar Date: Fri, 21 Aug 2020 19:37:52 +0530 Subject: [PATCH] Fixed local variable class name shadow rule violation Local variables should not shadow class fields [RSPEC-1117](https://rules.sonarsource.com/java/RSPEC-1117) --- .../samples/petclinic/vet/VetController.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/springframework/samples/petclinic/vet/VetController.java b/src/main/java/org/springframework/samples/petclinic/vet/VetController.java index fb5e321ba..e3c32a768 100644 --- a/src/main/java/org/springframework/samples/petclinic/vet/VetController.java +++ b/src/main/java/org/springframework/samples/petclinic/vet/VetController.java @@ -30,10 +30,10 @@ import java.util.Map; @Controller class VetController { - private final VetRepository vets; + private final VetRepository vetRepository; public VetController(VetRepository clinicService) { - this.vets = clinicService; + this.vetRepository = clinicService; } @GetMapping("/vets.html") @@ -41,7 +41,7 @@ class VetController { // Here we are returning an object of type 'Vets' rather than a collection of Vet // objects so it is simpler for Object-Xml mapping Vets vets = new Vets(); - vets.getVetList().addAll(this.vets.findAll()); + vets.getVetList().addAll(this.vetRepository.findAll()); model.put("vets", vets); return "vets/vetList"; } @@ -51,7 +51,7 @@ class VetController { // Here we are returning an object of type 'Vets' rather than a collection of Vet // objects so it is simpler for JSon/Object mapping Vets vets = new Vets(); - vets.getVetList().addAll(this.vets.findAll()); + vets.getVetList().addAll(this.vetRepository.findAll()); return vets; }