DevFW-CICD/spring-petclinic
16
0
Fork 1
mirror of https://github.com/spring-projects/spring-petclinic.git synced 2025-07-22 15:25:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor remove long method& primitive obession

Browse source
This commit is contained in:
abdelrahmanassem 2024-12-27 13:57:09 +02:00
parent 1aa1311497
commit 902a9f3057
1 changed files with 16 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
src/main/java/org/springframework/samples/petclinic/owner/PetTypeFormatter.java
View file

@ -1,18 +1,3 @@
/*
* Copyright 2012-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.samples.petclinic.owner;
import org.springframework.beans.factory.annotation.Autowired;
@ -22,16 +7,10 @@ import org.springframework.stereotype.Component;
import java.text.ParseException;
import java.util.Collection;
import java.util.Locale;
import java.util.Optional;
/**
* Instructs Spring MVC on how to parse and print elements of type 'PetType'. Starting
* from Spring 3.0, Formatters have come as an improvement in comparison to legacy
* PropertyEditors. See the following links for more details: - The Spring ref doc:
* https://docs.spring.io/spring-framework/docs/current/spring-framework-reference/core.html#format
*
* @author Mark Fisher
* @author Juergen Hoeller
* @author Michael Isvy
* Formatter to parse and print 'PetType' elements.
*/
@Component
public class PetTypeFormatter implements Formatter<PetType> {
@ -50,13 +29,20 @@ public class PetTypeFormatter implements Formatter<PetType> {
@Override
public PetType parse(String text, Locale locale) throws ParseException {
Collection<PetType> findPetTypes = this.owners.findPetTypes();
for (PetType type : findPetTypes) {
if (type.getName().equals(text)) {
return type;
}
}
throw new ParseException("type not found: " + text, 0);
Optional<PetType> petType = findPetTypeByName(text);
return petType.orElseThrow(() -> new ParseException("PetType not found: " + text, 0));
}
/**
* Helper method to find a PetType by its name.
* @param name the name of the pet type to search for
* @return an Optional containing the PetType if found, or an empty Optional
*/
private Optional<PetType> findPetTypeByName(String name) {
return this.owners.findPetTypes()
.stream()
.filter(petType -> petType.getName().equalsIgnoreCase(name))
.findFirst();
}
}