From bdcaa85460a9598ac991793bd522ff9aa00a4a9b Mon Sep 17 00:00:00 2001 From: Dave Syer Date: Mon, 10 Jan 2022 08:21:14 +0000 Subject: [PATCH] Alternative approach with eager fetch --- .../samples/petclinic/owner/OwnerController.java | 5 ----- .../org/springframework/samples/petclinic/owner/Pet.java | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/main/java/org/springframework/samples/petclinic/owner/OwnerController.java b/src/main/java/org/springframework/samples/petclinic/owner/OwnerController.java index 0ddaff067..92f43e0a9 100644 --- a/src/main/java/org/springframework/samples/petclinic/owner/OwnerController.java +++ b/src/main/java/org/springframework/samples/petclinic/owner/OwnerController.java @@ -18,7 +18,6 @@ package org.springframework.samples.petclinic.owner; import java.util.List; import java.util.Map; -import javax.transaction.Transactional; import javax.validation.Valid; import org.springframework.data.domain.Page; @@ -154,13 +153,9 @@ class OwnerController { * @return a ModelMap with the model attributes for the view */ @GetMapping("/owners/{ownerId}") - @Transactional public ModelAndView showOwner(@PathVariable("ownerId") int ownerId) { ModelAndView mav = new ModelAndView("owners/ownerDetails"); Owner owner = this.owners.findById(ownerId); - for (Pet pet : owner.getPets()) { - pet.getVisits().size(); - } mav.addObject(owner); return mav; } diff --git a/src/main/java/org/springframework/samples/petclinic/owner/Pet.java b/src/main/java/org/springframework/samples/petclinic/owner/Pet.java index 3c389b0ee..a863c754f 100755 --- a/src/main/java/org/springframework/samples/petclinic/owner/Pet.java +++ b/src/main/java/org/springframework/samples/petclinic/owner/Pet.java @@ -52,7 +52,7 @@ public class Pet extends NamedEntity { @JoinColumn(name = "type_id") private PetType type; - @OneToMany(cascade = CascadeType.ALL, fetch = FetchType.LAZY) + @OneToMany(cascade = CascadeType.ALL, fetch = FetchType.EAGER) @JoinColumn(name = "pet_id") @OrderBy("visit_date ASC") private Set visits = new LinkedHashSet<>();